Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using dlopen with gnome-secret provider #12503

Closed
ehuss opened this issue Aug 15, 2023 · 0 comments · Fixed by #12518
Closed

Consider using dlopen with gnome-secret provider #12503

ehuss opened this issue Aug 15, 2023 · 0 comments · Fixed by #12518
Labels
A-credential-provider Area: credential provider for storing and retreiving credentials

Comments

@ehuss
Copy link
Contributor

ehuss commented Aug 15, 2023

@joshtriplett had the suggestion that we could change the gnome-secret provider to use dlopen to access the libsecret-1 shared library at runtime to sidestep the build issues. This would allow including it built-in to cargo without needing to worry about the build environment, or requiring it to be present on the user's system if they aren't using it. I don't know what the security implications of that might be, or how difficult it might be, but might be something to simplify the experience.

@ehuss ehuss added the A-credential-provider Area: credential provider for storing and retreiving credentials label Aug 15, 2023
@bors bors closed this as completed in 937b930 Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-credential-provider Area: credential provider for storing and retreiving credentials
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant