Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo-install unnecessarily rebuilds everything #5667

Closed
Keruspe opened this issue Jun 29, 2018 · 5 comments
Closed

cargo-install unnecessarily rebuilds everything #5667

Keruspe opened this issue Jun 29, 2018 · 5 comments

Comments

@Keruspe
Copy link
Contributor

Keruspe commented Jun 29, 2018

Starting with rust 1.27, if I run cargo build --release then cargo install, the latter syncs its crates.io local copy and rebuilds everything.
This didn't happen with rust 1.26.

Might be related to the latest failure in rust-lang/rust#51717 (comment) ?

@ehuss
Copy link
Contributor

ehuss commented Jun 29, 2018

I think this change was intentional, see #5327. You should have gotten a warning:

warning: To build the current package use `cargo build`, 
to install the current package run `cargo install --path .`

@Keruspe
Copy link
Contributor Author

Keruspe commented Jul 2, 2018

@ehuss I fail to see how that could be related.

I'm a distribution packager and our install phase doesn't have access to the network so resyncing crates.io breaks stuff, and rebuilding everything that was built just before during the compile phase doesn't seem necessary...

@Keruspe
Copy link
Contributor Author

Keruspe commented Jul 2, 2018

Actually, this is probably a duplicate of #5662

@ehuss
Copy link
Contributor

ehuss commented Jul 2, 2018

Ah, sorry, I misunderstood. Indeed using cargo install in a workspace does not seem to be working as intended.

@alexcrichton
Copy link
Member

Indeed I believe this is a duplicate! Closing in favor of #5662

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants