Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Rust provided objects, libraries and binaries meant for self-contained linkage to separate directory #310

Closed
1 of 3 tasks
mati865 opened this issue Jun 17, 2020 · 7 comments
Closed
1 of 3 tasks

Move Rust provided objects, libraries and binaries meant for self-contained linkage to separate directory #310

mati865 opened this issue Jun 17, 2020 · 7 comments
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team

Comments

@mati865
Copy link
Contributor

mati865 commented Jun 17, 2020 •
edited
Loading

Proposal

This affects only three targets: windows-gnu, linux-musl, -wasi.
Currently startup objects (all three targets) and libraries (windows-gnu) and placed next to Rust's own libraries like libstd.
This causes various problems, e.g. somebody wants to link external libraries with Rust but CRT shipped by Rust is incompatible with the one used to link external library.
For windows-gnu there is also linker shipped.

rust-lang/rust#68887 (comment) explains how to resolve that limitation by creating native and self-contained modes. Native mode would avoid using anything located inside self-contained directory.

rust-lang/rust#72999 is preparation that moves things but retains old user visible behaviour (everything is linked just like before, only the paths are different).

Mentors or Reviewers

@petrochenkov

Process

The main points of the Major Change Process is as follows:

  • File an issue describing the proposal.
  • A compiler team member or contributor who is knowledgeable in the area can second by writing @rustbot second.
    • Finding a "second" suffices for internal changes. If however you are proposing a new public-facing feature, such as a -C flag, then full team check-off is required.
    • Compiler team members can initiate a check-off via @rfcbot fcp merge on either the MCP or the PR.
  • Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.

You can read more about Major Change Proposals on forge.

Comments

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.
@mati865 mati865 added T-compiler Add this label so rfcbot knows to poll the compiler team major-change A proposal to make a major change to rustc labels Jun 17, 2020
@rustbot
Copy link
Collaborator

rustbot commented Jun 17, 2020

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

@rustbot rustbot added the to-announce Announce this issue on triage meeting label Jun 17, 2020
@mati865 mati865 changed the title Move Move Rust provided objects, libraries and binaries meant for self-contained linkage to separate directory Jun 17, 2020
@nikomatsakis

This comment has been minimized.

Sign in to view
@mati865

This comment has been minimized.

Sign in to view
@spastorino spastorino removed the to-announce Announce this issue on triage meeting label Jun 17, 2020
@mati865 mati865 mentioned this issue Jul 2, 2020
Closed
@mati865

This comment has been minimized.

Sign in to view
@rustbot
Copy link
Collaborator

rustbot commented Jul 2, 2020

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

@rustbot rustbot added the to-announce Announce this issue on triage meeting label Jul 2, 2020
@spastorino spastorino removed the to-announce Announce this issue on triage meeting label Jul 2, 2020
@nikomatsakis
Copy link
Contributor

@rustbot second

@rustbot rustbot added the final-comment-period The FCP has started, most (if not all) team members are in agreement label Jul 16, 2020
@mati865
Copy link
Contributor Author

mati865 commented Jul 27, 2020

Are the docs up-to-date and FCP should last 10 days?

@spastorino spastorino added major-change-accepted A major change proposal that was accepted and removed final-comment-period The FCP has started, most (if not all) team members are in agreement labels Jul 29, 2020
@rustbot rustbot added the to-announce Announce this issue on triage meeting label Jul 29, 2020
@spastorino spastorino removed the to-announce Announce this issue on triage meeting label Jul 29, 2020
@mati865 mati865 mentioned this issue Aug 12, 2020
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@spastorino @nikomatsakis @mati865 @Mark-Simulacrum @rustbot