Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a system for registering function pointers similar to registering queries #678

Closed
1 of 3 tasks
oli-obk opened this issue Sep 21, 2023 · 4 comments
Closed
1 of 3 tasks
Labels
major-change A proposal to make a major change to rustc T-compiler Add this label so rfcbot knows to poll the compiler team

Comments

@oli-obk
Copy link
Contributor

oli-obk commented Sep 21, 2023

Proposal

We have some queries, that should not be queries, but only are queries, because their body needs to live in a crate other than rustc_middle. Queries are overkill for this and have various problems if the arguments are not incremental/query-cache safe (see rust-lang/rust#115819). Instead I propose to add a way to add function pointers to Providers that will then get stored in TyCtxt and have a method generated on the TyCtxt that invokes the function pointer.

Mentors or Reviewers

The implementation should be fairly straight forward, so anyone from T-compiler or T-compiler-contributors

Process

The main points of the Major Change Process are as follows:

  • File an issue describing the proposal.
  • A compiler team member or contributor who is knowledgeable in the area can second by writing @rustbot second.
    • Finding a "second" suffices for internal changes. If however, you are proposing a new public-facing feature, such as a -C flag, then full team check-off is required.
    • Compiler team members can initiate a check-off via @rfcbot fcp merge on either the MCP or the PR.
  • Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.

You can read more about Major Change Proposals on forge.

Comments

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

@oli-obk oli-obk added T-compiler Add this label so rfcbot knows to poll the compiler team major-change A proposal to make a major change to rustc labels Sep 21, 2023
@rustbot
Copy link
Collaborator

rustbot commented Sep 21, 2023

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

cc @rust-lang/compiler @rust-lang/compiler-contributors

@rustbot rustbot added the to-announce Announce this issue on triage meeting label Sep 21, 2023
@lcnr
Copy link
Contributor

lcnr commented Sep 21, 2023

😁 there is already the accepted MCP #395 which is pretty much exactly equal but has never been implemented. I guess given that it has been more than 2.5 years

@rustbot second

@rustbot rustbot added the final-comment-period The FCP has started, most (if not all) team members are in agreement label Sep 21, 2023
@RalfJung
Copy link
Member

So, the 10-day period is already over then, since it started 2.5 years ago? ;)

@apiraino
Copy link
Contributor

I would close as "duplicate" (if such a label makes sense)

@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Sep 21, 2023
@apiraino apiraino removed the final-comment-period The FCP has started, most (if not all) team members are in agreement label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major-change A proposal to make a major change to rustc T-compiler Add this label so rfcbot knows to poll the compiler team
Projects
None yet
Development

No branches or pull requests

5 participants