Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

number of "completed jobs" change after crater completed #735

Closed
matthiaskrgr opened this issue Aug 31, 2024 · 6 comments
Closed

number of "completed jobs" change after crater completed #735

matthiaskrgr opened this issue Aug 31, 2024 · 6 comments

Comments

@matthiaskrgr
Copy link
Member

matthiaskrgr commented Aug 31, 2024

rust-lang/rust#129660 (comment)

https://crater.rust-lang.org/ex/crater-rollup-uwu

the crater run was done and report was generated. I watched the summary page and hit f5 a couple of times and you can see "completed jobs" number go down???

Note that another crater job was also running directly after that one. https://crater.rust-lang.org/ex/pr-126452-1

@matthiaskrgr
Copy link
Member Author

crater.mp4

@matthiaskrgr matthiaskrgr changed the title "completed jobs" change after job is done number of "completed jobs" change after crater completed Aug 31, 2024
@matthiaskrgr
Copy link
Member Author

it seems that past crater runs have their "completed jobs" reduced to "0/0" ??
https://crater.rust-lang.org/ex/pr-129466

I guess something is a bit broken as it "adds" more completed jobs to the current run, crater accidentally subtracts them from the previous run? 😅

@Mark-Simulacrum
Copy link
Member

Previous runs are (mostly) pruned from the database, so we don't keep track of the count of jobs etc. anymore.

@matthiaskrgr
Copy link
Member Author

would it make sense to store this as a 2 static numbers somewhere just for display?

@Mark-Simulacrum
Copy link
Member

It would be a hassle and doesn't seem worth it to me. Why do you care about previous runs? The report is stored in S3 and has links to e.g. tarballs containing all logs, so the UI doesn't seem particularly useful.

@matthiaskrgr
Copy link
Member Author

Just found that it looked very weird...
But understandable, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants