Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crates with docs built by the broken 2021-04-24 nightly should be rebuilt #1399

Closed
lf- opened this issue May 11, 2021 · 5 comments
Closed

Crates with docs built by the broken 2021-04-24 nightly should be rebuilt #1399

lf- opened this issue May 11, 2021 · 5 comments
Labels
A-builds Area: Building the documentation for a crate C-bug Category: This is a bug

Comments

@lf-
Copy link

lf- commented May 11, 2021

There was a bug fixed here: rust-lang/rust#84552 where impl blocks were closed by default, breaking links from search and making it hard to see struct methods. It was fixed a couple of days later, although there was no nightly for a week starting slightly before the fix was merged since rustfmt had a build breakage.

It appears that docs.rs has built some crates with this broken nightly version, for instance, chalk-ir: see this broken page https://docs.rs/chalk-ir/0.66.0/chalk_ir/struct.ConcreteConst.html and the crate builds page https://docs.rs/crate/chalk-ir/0.66.0/builds

These should be rebuilt :)

@jyn514
Copy link
Member

jyn514 commented Jun 12, 2021

See also #464.

This is possible but it will be a lot of crates:

cratesfyi=> select count(*) from releases where doc_rustc_version like '%2021-04-24%';
 count 
-------
  4078
(1 row)

@ratijas
Copy link
Contributor

ratijas commented Aug 2, 2021

I wonder, if this is still relevant few months later

@lf-
Copy link
Author

lf- commented Aug 2, 2021

Are there any crates where the latest version was built with the broken nightly?

@jyn514
Copy link
Member

jyn514 commented Aug 16, 2021

@lf- yes

cratesfyi=> select count(*) from releases inner join crates on releases.id = crates.latest_version_id where doc_rustc_version like '%2021-04-24%';
 count 
-------
  1065
(1 row)

@syphar syphar added C-bug Category: This is a bug S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work. A-builds Area: Building the documentation for a crate labels Aug 2, 2023
@syphar
Copy link
Member

syphar commented Sep 27, 2023

541 latest releases remained that were built this this nightly version.

I just queued the rebuilds for these, with very low priority.

@syphar syphar removed the S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work. label Sep 27, 2023
@syphar syphar closed this as completed Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-builds Area: Building the documentation for a crate C-bug Category: This is a bug
Projects
None yet
Development

No branches or pull requests

4 participants