Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme: Option to prefer system UI theme in theme selector #2108

Closed
ishank-s opened this issue Apr 16, 2023 · 3 comments
Closed

Theme: Option to prefer system UI theme in theme selector #2108

ishank-s opened this issue Apr 16, 2023 · 3 comments

Comments

@ishank-s
Copy link

No description provided.

@jyn514
Copy link
Member

jyn514 commented May 2, 2023

Don't we already support this?
image

@Nemo157
Copy link
Member

Nemo157 commented May 3, 2023

Yes, this has been implementing in rustdoc for a few years now, only if you open really old docs will it be missing. Docs.rs itself doesn't have a theme selector, but will follow whatever the last loaded docs do. This does mean that navigating to a non-rustdoc page like https://docs.rs won't auto-update if your system preference has changed, but as long as you have any rustdoc page open (and JS enabled) we propagate the theme selection throughout all docs.rs pages instantly.

@jyn514
Copy link
Member

jyn514 commented May 3, 2023

Ok, I'm going to close this as a duplicate of #464 then

@jyn514 jyn514 closed this as completed May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants