Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

noscript fallback? #419

Closed
rw opened this issue Oct 2, 2019 · 7 comments
Closed

noscript fallback? #419

rw opened this issue Oct 2, 2019 · 7 comments

Comments

@rw
Copy link

rw commented Oct 2, 2019

Thanks for your hard work on docs.rs!

I really liked how the previous version(s) of docs.rs didn't need javascript to render essential content.

Is there an option to make the new docs.rs not require javascript to render (what seems to be 100%) static content?

@GuillaumeGomez
Copy link
Member

What isn't working with the noscript?

@rw
Copy link
Author

rw commented Oct 2, 2019

@GuillaumeGomez The following doesn't show the "Methods"/"Implementations" sections with Javascript disabled in my Chrome browser:

https://docs.rs/slab/0.4.2/slab/struct.Slab.html

I see an error in the console that the following file was not found, maybe that's the problem?

https://docs.rs/noscript-20190110-1.33.0-nightly-c2d381d39.css

@GuillaumeGomez
Copy link
Member

Oh I see. Opening an issue on rustdoc about it.

@jyn514
Copy link
Member

jyn514 commented Nov 4, 2019

This is fixed in latest docs.rs, see e.g. https://docs.rs/odrive-rs/0.1.0/odrive_rs/ascii/struct.ODrive.html. Fixing slab/0.4.2 would require #464 which is separate from the problem itself.

@jyn514 jyn514 closed this as completed Nov 4, 2019
@rw
Copy link
Author

rw commented Nov 9, 2019

@GuillaumeGomez @jyn514 Unfortunately this appears to still occur, at least in the ODrive example you provide.

The following sections still have "display: none" set:

  • Trait Implementations
  • Auto Trait Implementations
  • Blanket Implementations

@GuillaumeGomez
Copy link
Member

With the last version of ODrive?

@rw
Copy link
Author

rw commented Nov 11, 2019

@GuillaumeGomez Thanks for the quick response. I think it's an issue with how Chrome and uBlock Origin interact. I don't know the root cause.

If I disable Javascript in the Chrome tab, and disable Javascript in uBlock Origin, the page does not render fully.

Any other combination of enable/disable causes the page to render fully.

I suspect that a lot of Rust users use ad blockers, so it might be worth keeping an eye on this. However, I don't know the root cause.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants