Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button in dark theme has dark text #547

Closed
FranklinYu opened this issue Jan 6, 2020 · 6 comments · Fixed by #807
Closed

Button in dark theme has dark text #547

FranklinYu opened this issue Jan 6, 2020 · 6 comments · Fixed by #807
Labels
E-easy Effort: Should be easy to implement and would make a good first PR

Comments

@FranklinYu
Copy link

This is a styling issue of dark theme. Currently it’s:

image

The two buttons should be light color in dark background. Following style is recommended:

#theme-choices button {
    color: #e0e0e0;
}

Color came from button border. I didn’t make a Pull Request because I can’t find the dark style in this repository. Recommended label: minor, easy.

@GuillaumeGomez
Copy link
Member

This is a fixed bug in rustdoc. This crate certainly has been generated some time ago with an older version.

@jyn514
Copy link
Member

jyn514 commented Jan 6, 2020

Duplicate of #464

@jyn514 jyn514 marked this as a duplicate of #464 Jan 6, 2020
@jyn514 jyn514 closed this as completed Jan 6, 2020
@Elinvynia
Copy link

It still happened to me, with a crate that was pushed just a few minutes ago: https://docs.rs/tranquility/0.0.7/tranquility/

The crate itself was created on 2020-04-03: https://crates.io/crates/tranquility

@GuillaumeGomez
Copy link
Member

It's weird because the rules are in rustdoc and are working fine on rustdoc side. I think this is conflict coming from docs.rs' style. Re-opening!

@GuillaumeGomez GuillaumeGomez reopened this Jun 1, 2020
@Nemo157
Copy link
Member

Nemo157 commented Jun 1, 2020

html, button, input, select, textarea,
.pure-g [class *= "pure-u"] {
font-family: $font-family-sans;
color: $color-standard;
}

I think button can be dropped from this selector, the only <button> on the site ("Search" and "I'm feeling lucky") override it via other styles. (Would be good to investigate whether the other selectors are still relevant as well).

@Nemo157 Nemo157 added the E-easy Effort: Should be easy to implement and would make a good first PR label Jun 1, 2020
@GuillaumeGomez
Copy link
Member

I thik it's worth giving it a try. Wanna do it @Nemo157 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-easy Effort: Should be easy to implement and would make a good first PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants