-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider using iframes for rustdoc HTML files #679
Comments
An alternative to iframes or similar is to instead pre-run HTML parsing on rustdoc output and store the header and body and classes separately, such that we could then template them in quickly. |
That doesn't help with the existing HTML content, though. Also it would triple the number of files we store on S3, which would have some overhead. |
Well, we could store new files as such (which would over time migrate us over to the new format). With regards to S3, there's no reason we can't pack in theory, for example storing the HTML like: u64 length of head, head raw, body raw |
Ok, that sounds feasible at least. The other things we would get from inline frames though are
|
We should not use iframes:
If we want to remove parsing, Mark's solution is more feasible. |
One of the things #671 (comment), #668, servo/html5ever#414 show is that the live server's performance is very heavily tied to the html parsing (outside of builds). It would be better to instead serve the rustdoc HTML inside of an iframe, but that would require a lot of UI testing we don't currently have.
Related issues: #595, #167
cc @Mark-Simulacrum, @pietroalbini
The text was updated successfully, but these errors were encountered: