Skip to content
This repository has been archived by the owner on Dec 29, 2022. It is now read-only.

RLS nightly not working #756

Closed
sophiajt opened this issue Mar 8, 2018 · 11 comments
Closed

RLS nightly not working #756

sophiajt opened this issue Mar 8, 2018 · 11 comments

Comments

@sophiajt
Copy link

sophiajt commented Mar 8, 2018

There might be an obvious fix, but the RLS isn't working for me as of the most recent nightly.

The spinner spins, but when it stops nothing has occurred, and there are no warnings about the RLS crashing. This is with the latest version of the vs code plugin as well.

I'm on Windows, if that helps.

@sophiajt
Copy link
Author

sophiajt commented Mar 8, 2018

Poked around a bit and seemed to have knocked it out of the bad state. Not sure how I got in it. If I can reliably repro, I'll reopen.

@sophiajt sophiajt closed this as completed Mar 8, 2018
@sophiajt sophiajt reopened this Mar 8, 2018
@sophiajt
Copy link
Author

sophiajt commented Mar 8, 2018

Reopening. It seems that you can get it to fix itself if you change the user settings. But regular editing will eventually (especially adding or removing 'extern crate' statements) will get it into a state where it no longer functions.

@71
Copy link

71 commented Mar 8, 2018

@jonathandturner Hey, can you expand on "changing the user settings"? I might have the same problem as you do. Thanks.

@sophiajt
Copy link
Author

sophiajt commented Mar 8, 2018

If I open the user settings and poke lines like:

"rust-client.channel": "nightly"

It seems to make it work for a while.

@71
Copy link

71 commented Mar 8, 2018

Oh, then it appears we have different problems. Mine crashes after a few dozen seconds with no backtrace.

@alexheretic
Copy link
Member

Perhaps related to an issue with latest nightly where it outputs to stdout after a compiler panic rust-lang/rust#48816. vscode-jsonrpc is irrecoverably broken by this.

So previously subsequent builds may have worked after a rustc panic, now you'll need to restart your client comms.

@gilescope
Copy link

Any news? Apparently RLS nightlies are stopping Rust nightlies.

@gilescope
Copy link

Looks like rust-lang/rust#48993 will fix this. Good sluthing!

@mati865
Copy link
Contributor

mati865 commented Mar 14, 2018

Any news? Apparently RLS nightlies are stopping Rust nightlies.

Fixed by rust-lang/rust#49014

@alexheretic
Copy link
Member

The particular stdout abuse I reproduced is now fixed and available in nightly-2018-03-14. Rustc panics may still happen but the rls->client comms won't be broken, until the next time something prints.

Does this fix this issue @jonathandturner?

@nrc
Copy link
Member

nrc commented Apr 19, 2018

Not seen by reporter for a while, presumed fixed.

@nrc nrc closed this as completed Apr 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants