-
Notifications
You must be signed in to change notification settings - Fork 257
RLS nightly not working #756
Comments
Poked around a bit and seemed to have knocked it out of the bad state. Not sure how I got in it. If I can reliably repro, I'll reopen. |
Reopening. It seems that you can get it to fix itself if you change the user settings. But regular editing will eventually (especially adding or removing 'extern crate' statements) will get it into a state where it no longer functions. |
@jonathandturner Hey, can you expand on "changing the user settings"? I might have the same problem as you do. Thanks. |
If I open the user settings and poke lines like:
It seems to make it work for a while. |
Oh, then it appears we have different problems. Mine crashes after a few dozen seconds with no backtrace. |
Perhaps related to an issue with latest nightly where it outputs to stdout after a compiler panic rust-lang/rust#48816. vscode-jsonrpc is irrecoverably broken by this. So previously subsequent builds may have worked after a rustc panic, now you'll need to restart your client comms. |
Any news? Apparently RLS nightlies are stopping Rust nightlies. |
Looks like rust-lang/rust#48993 will fix this. Good sluthing! |
Fixed by rust-lang/rust#49014 |
The particular stdout abuse I reproduced is now fixed and available in nightly-2018-03-14. Rustc panics may still happen but the rls->client comms won't be broken, until the next time something prints. Does this fix this issue @jonathandturner? |
Not seen by reporter for a while, presumed fixed. |
There might be an obvious fix, but the RLS isn't working for me as of the most recent nightly.
The spinner spins, but when it stops nothing has occurred, and there are no warnings about the RLS crashing. This is with the latest version of the vs code plugin as well.
I'm on Windows, if that helps.
The text was updated successfully, but these errors were encountered: