Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make BindgenOptions private #1000

Merged
merged 1 commit into from
Sep 18, 2017

Conversation

pepyakin
Copy link
Contributor

Fixes #958

r? @fitzgen

@highfive
Copy link

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @fitzgen (or someone else) soon.

src/lib.rs Outdated
#[derive(Debug)]
#[deprecated]
pub struct BindgenOptions {
pub(crate) struct BindgenOptions {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's in the root, so it can just be private.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks!

@pepyakin pepyakin changed the title Make BindgenOptions pub(crate) Make BindgenOptions private Sep 18, 2017
@fitzgen
Copy link
Member

fitzgen commented Sep 18, 2017

Looks great, thanks @pepyakin!

@bors-servo r+

@bors-servo
Copy link

📌 Commit e8e6f37 has been approved by fitzgen

@bors-servo
Copy link

⌛ Testing commit e8e6f37 with merge da942c4...

bors-servo pushed a commit that referenced this pull request Sep 18, 2017
@bors-servo
Copy link

☀️ Test successful - status-travis
Approved by: fitzgen
Pushing da942c4 to master...

@bors-servo bors-servo merged commit e8e6f37 into rust-lang:master Sep 18, 2017
@bors-servo bors-servo mentioned this pull request Sep 18, 2017
8 tasks
@pepyakin pepyakin deleted the hide-bindgen-options branch September 18, 2017 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants