Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make whitelisted_var consistant with CLI flags #989

Merged
merged 1 commit into from
Sep 14, 2017
Merged

Make whitelisted_var consistant with CLI flags #989

merged 1 commit into from
Sep 14, 2017

Conversation

aeleos
Copy link
Contributor

@aeleos aeleos commented Sep 14, 2017

Closes #986

This is my first time contributing to rust so hopefully I did everything right, otherwise let me know.

@fitzgen
Copy link
Member

fitzgen commented Sep 14, 2017

Perfect! Thank you very much @aeleos :)

Are you interested in contributing some more? One of the issues labeled E-less-easy could be a good next step, now that you're familiar with the basics of bindgen hacking :)

@bors-servo r+

@bors-servo
Copy link

📌 Commit 2c86445 has been approved by fitzgen

bors-servo pushed a commit that referenced this pull request Sep 14, 2017
Make whitelisted_var consistant with CLI flags

Closes #986

This is my first time contributing to rust so hopefully I did everything right, otherwise let me know.
@bors-servo
Copy link

⌛ Testing commit 2c86445 with merge f6002ab...

@bors-servo
Copy link

☀️ Test successful - status-travis
Approved by: fitzgen
Pushing f6002ab to master...

@bors-servo bors-servo merged commit 2c86445 into rust-lang:master Sep 14, 2017
@aeleos
Copy link
Contributor Author

aeleos commented Sep 14, 2017

@fitzgen yea I am interested in contributing more, I will take a look at the other issues and see if anything looks doable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants