Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta issue for Rust API Guidelines #1798

Open
22 of 66 tasks
mcarton opened this issue May 27, 2017 · 9 comments
Open
22 of 66 tasks

Meta issue for Rust API Guidelines #1798

mcarton opened this issue May 27, 2017 · 9 comments
Labels
L-guidelines Lint: Related to the Rust API Guidelines

Comments

@mcarton
Copy link
Member

mcarton commented May 27, 2017

Let's see what makes sense to get into Clippy or not from the Rust API Guidelines.

Check the box if a lint or issue already exist for an item. See also is:issue is:open label:A-guidelines.

@kennytm
Copy link
Member

kennytm commented May 28, 2017

C-PANIC-DOC should point to #1791, C-DOCS-RS should point to #1788 or a new issue.

@mcarton mcarton added the L-guidelines Lint: Related to the Rust API Guidelines label May 28, 2017
@killercup
Copy link
Member

killercup commented May 29, 2017

Nice work!

(You should use URLs with the commit hash in them (press y on github.com) so they continue to work in the future.)

@mcarton
Copy link
Member Author

mcarton commented May 29, 2017

Thanks! I volontarily did not do that for this so that we point to the latest version of the guidelines. This might mean that we get broken links once in a while but that'll mean that the list here is outdated.

@clarfonthey
Copy link
Contributor

Note that C-EXAMPLE is covered by #1454.

@mcarton
Copy link
Member Author

mcarton commented Jun 10, 2017

Not quite, C-EXAMPLE is about not having an example, #1454 is about having a non-relevant example.

@killercup
Copy link
Member

As predicted, the links no longer work. Now, how using links like this one instead?

@Susurrus
Copy link

Types eagerly implement common traits (C-COMMON-TRAITS)

rustc has missing-copy-implementations for Copy and missing-debug-implementations for Debug, but I don't see anything in rustc or clippy for any of the other traits:

  • Clone
  • Eq
  • Ord
  • PartialOrd
  • Hash
  • Display
  • Default

This was checked off in the original checklist, so I wanted to double-check I wasn't missing anything.

@mcarton
Copy link
Member Author

mcarton commented Feb 4, 2019

@Susurrus I split the list into sub-lists and unchecked the main item.

@philipcraig

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L-guidelines Lint: Related to the Rust API Guidelines
Projects
None yet
Development

No branches or pull requests

6 participants