Skip to content

Commit

Permalink
Rollup merge of #127588 - uweigand:s390x-f16-doctests, r=tgross35
Browse files Browse the repository at this point in the history
core: Limit remaining f16 doctests to x86_64 linux

On s390x, every use of the f16 data type will currently ICE due to llvm/llvm-project#50374, causing doctest failures on the platform.

Most doctests were already restricted to certain platforms, so fix this by likewise restricting the remaining five.
  • Loading branch information
matthiaskrgr authored Jul 11, 2024
2 parents 6fd9555 + 0065763 commit 380c787
Showing 1 changed file with 15 additions and 0 deletions.
15 changes: 15 additions & 0 deletions library/core/src/num/f16.rs
Original file line number Diff line number Diff line change
Expand Up @@ -353,12 +353,15 @@ impl f16 {
///
/// ```
/// #![feature(f16)]
/// # // FIXME(f16_f128): LLVM crashes on s390x, llvm/llvm-project#50374
/// # #[cfg(all(target_arch = "x86_64", target_os = "linux"))] {
///
/// let f = 7.0_f16;
/// let g = -7.0_f16;
///
/// assert!(f.is_sign_positive());
/// assert!(!g.is_sign_positive());
/// # }
/// ```
#[inline]
#[must_use]
Expand All @@ -376,12 +379,15 @@ impl f16 {
///
/// ```
/// #![feature(f16)]
/// # // FIXME(f16_f128): LLVM crashes on s390x, llvm/llvm-project#50374
/// # #[cfg(all(target_arch = "x86_64", target_os = "linux"))] {
///
/// let f = 7.0_f16;
/// let g = -7.0_f16;
///
/// assert!(!f.is_sign_negative());
/// assert!(g.is_sign_negative());
/// # }
/// ```
#[inline]
#[must_use]
Expand Down Expand Up @@ -694,9 +700,12 @@ impl f16 {
///
/// ```
/// #![feature(f16)]
/// # // FIXME(f16_f128): LLVM crashes on s390x, llvm/llvm-project#50374
/// # #[cfg(all(target_arch = "x86_64", target_os = "linux"))] {
///
/// let bytes = 12.5f16.to_be_bytes();
/// assert_eq!(bytes, [0x4a, 0x40]);
/// # }
/// ```
#[inline]
#[unstable(feature = "f16", issue = "116909")]
Expand All @@ -715,9 +724,12 @@ impl f16 {
///
/// ```
/// #![feature(f16)]
/// # // FIXME(f16_f128): LLVM crashes on s390x, llvm/llvm-project#50374
/// # #[cfg(all(target_arch = "x86_64", target_os = "linux"))] {
///
/// let bytes = 12.5f16.to_le_bytes();
/// assert_eq!(bytes, [0x40, 0x4a]);
/// # }
/// ```
#[inline]
#[unstable(feature = "f16", issue = "116909")]
Expand All @@ -742,6 +754,8 @@ impl f16 {
///
/// ```
/// #![feature(f16)]
/// # // FIXME(f16_f128): LLVM crashes on s390x, llvm/llvm-project#50374
/// # #[cfg(all(target_arch = "x86_64", target_os = "linux"))] {
///
/// let bytes = 12.5f16.to_ne_bytes();
/// assert_eq!(
Expand All @@ -752,6 +766,7 @@ impl f16 {
/// [0x40, 0x4a]
/// }
/// );
/// # }
/// ```
#[inline]
#[unstable(feature = "f16", issue = "116909")]
Expand Down

0 comments on commit 380c787

Please sign in to comment.