From d9038fc3b3222c678bdf2d06b896322976eaacf5 Mon Sep 17 00:00:00 2001 From: Alex Crichton Date: Thu, 7 Aug 2014 19:38:18 -0700 Subject: [PATCH] rustdoc: Set a nonzero exit status on failure Now that rustdoc is spawning a child task, the program won't exit with a default error code if the main task fails (because it never fails). This commit forces the main task to wait for a child task in order to correctly propagate failure. Closes #16341 --- src/librustdoc/lib.rs | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/librustdoc/lib.rs b/src/librustdoc/lib.rs index fb974403858a0..6c254b621775c 100644 --- a/src/librustdoc/lib.rs +++ b/src/librustdoc/lib.rs @@ -120,9 +120,16 @@ pub fn main() { // So, in summary, it is unknown why this is necessary, what it is // preventing, or what the actual bug is. In the meantime, this allows // --test to work on windows, which seems good, right? Fun times. + let (tx, rx) = channel(); spawn(proc() { std::os::set_exit_status(main_args(std::os::args().as_slice())); + tx.send(()); }); + + // If the task failed, set an error'd exit status + if rx.recv_opt().is_err() { + std::os::set_exit_status(std::rt::DEFAULT_ERROR_CODE); + } } pub fn opts() -> Vec {