Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std lib compile errors for uwp-windows-msvc targets #103233

Closed
korejan opened this issue Oct 19, 2022 · 4 comments · Fixed by #103637
Closed

std lib compile errors for uwp-windows-msvc targets #103233

korejan opened this issue Oct 19, 2022 · 4 comments · Fixed by #103637
Assignees
Labels
C-bug Category: This is a bug. regression-untriaged Untriaged performance or correctness regression. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Comments

@korejan
Copy link

korejan commented Oct 19, 2022

Building std library (-Zbuild-std) with nightly for uwp-windows-msvc targets has been failing with compile errors since around after 17/10/22

   Compiling panic_abort v0.0.0 (C:\Users\runneradmin\.rustup\toolchains\nightly-x86_64-pc-windows-msvc\lib\rustlib\src\rust\library\panic_abort)
error[E0425]: cannot find function, tuple struct or tuple variant `GetConsoleMode` in module `c`
  --> C:\Users\runneradmin\.rustup\toolchains\nightly-x86_64-pc-windows-msvc\lib\rustlib\src\rust\library\std\src\sys\windows\io.rs:99:11
   |
99 |     if c::GetConsoleMode(handle, &mut out) != 0 {
   |           ^^^^^^^^^^^^^^ not found in `c`

error[E0425]: cannot find function, tuple struct or tuple variant `GetConsoleMode` in module `c`
   --> C:\Users\runneradmin\.rustup\toolchains\nightly-x86_64-pc-windows-msvc\lib\rustlib\src\rust\library\std\src\sys\windows\io.rs:112:19
    |
112 |             && c::GetConsoleMode(std_handle, &mut out) != 0
    |                   ^^^^^^^^^^^^^^ not found in `c`

I expected to see this happen:

Last successeful build on 16/10:

https://github.com/korejan/ALXR-nightly/actions/runs/3257338692/jobs/5348560568

Instead, this happened:

Lastest failed build:

https://github.com/korejan/ALXR-nightly/actions/runs/3277318460/jobs/5394484131

Version it worked on

It most recently worked on: rustc 1.66.0-nightly (bf15a9e 2022-10-14)

Version with regression

rustc --version --verbose:

rustc 1.66.0-nightly (b8b5caee0 2022-10-16)

Backtrace

Backtrace

<backtrace>

@korejan korejan added C-bug Category: This is a bug. regression-untriaged Untriaged performance or correctness regression. labels Oct 19, 2022
@rustbot rustbot added the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Oct 19, 2022
@apiraino apiraino added T-libs Relevant to the library team, which will review and decide on the PR/issue. and removed I-prioritize Issue: Indicates that prioritization has been requested for this issue. labels Oct 19, 2022
@korejan
Copy link
Author

korejan commented Oct 27, 2022

Hey, is anyone looking into this because ALXR ci (uwp) builds are failing for over a week. Should this issue be posted in another repo?

@thomcc
Copy link
Member

thomcc commented Oct 27, 2022

This is the right repo, but it fell through the cracks for whatever reason. I can get to it this weekend.

@thomcc thomcc self-assigned this Oct 27, 2022
@korejan
Copy link
Author

korejan commented Oct 27, 2022

This is the right repo, but it fell through the cracks for whatever reason. I can get to it this weekend.

Thank you :)

@ChrisDenton
Copy link
Member

Oh, sorry I missed this! Since 10.0.16299 console functions are available on UWP (see APIs present on all Windows 10 devices). So I think the thing to do here is to simply stop making the function conditionally imported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug. regression-untriaged Untriaged performance or correctness regression. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants