Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustc should fail CI on allow(incomplete_features) #108045

Open
BoxyUwU opened this issue Feb 14, 2023 · 0 comments
Open

rustc should fail CI on allow(incomplete_features) #108045

BoxyUwU opened this issue Feb 14, 2023 · 0 comments
Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work.

Comments

@BoxyUwU
Copy link
Member

BoxyUwU commented Feb 14, 2023

I do not think it is a good idea for rustc to be depending on incomplete features, it doesn't feel particularly fair to people working on said features that when they attempt to make progress on a broken feature they would have to deal with cfg(bootstrap) pain and generally fixing rustc itself from usage of the feature. Also just generally depending on broken or unsound features in rustc is probably not good 😆

Recently stumbled on #107937 which attempts to enable generic_const_expr a (very) broken/incomplete feature.

As far as I can tell there's only one usage of allow(incomplete_features) and that's to enable adt_const_params which will likely be moved off of incomplete_features soonish

@BoxyUwU BoxyUwU added S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. A-meta Area: Issues & PRs about the rust-lang/rust repository itself labels Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work.
Projects
None yet
Development

No branches or pull requests

1 participant