Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: invalid doc attribute #123293

Closed
Mark-Simulacrum opened this issue Mar 31, 2024 · 3 comments
Closed

regression: invalid doc attribute #123293

Mark-Simulacrum opened this issue Mar 31, 2024 · 3 comments
Labels
A-attributes Area: Attributes (`#[…]`, `#![…]`) regression-from-stable-to-stable Performance or correctness regression from one stable version to another. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Milestone

Comments

@Mark-Simulacrum
Copy link
Member


[INFO] [stdout] ---- src/lib.rs - (line 48) stdout ----
[INFO] [stdout] error: invalid `doc` attribute
[INFO] [stdout]   --> src/lib.rs:56:11
[INFO] [stdout]    |
[INFO] [stdout] 11 |     #[doc("This attribute will be applied on the `impl` block")] Left, Right:
[INFO] [stdout]    |           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[deny(invalid_doc_attributes)]` on by default
[INFO] [stdout] 
[INFO] [stdout] error: invalid `doc` attribute
[INFO] [stdout]   --> src/lib.rs:57:11
[INFO] [stdout]    |
[INFO] [stdout] 12 |     #[doc("This attribute will be applied on the `fn` block")] a + b -> Answer {
[INFO] [stdout]    |           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] error: aborting due to 2 previous errors

https://crater-reports.s3.amazonaws.com/beta-1.78-3/beta-2024-03-30/reg/operator-sugar-0.1.2/log.txt

@Mark-Simulacrum Mark-Simulacrum added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. regression-from-stable-to-beta Performance or correctness regression from stable to beta. labels Mar 31, 2024
@Mark-Simulacrum Mark-Simulacrum added this to the 1.78.0 milestone Mar 31, 2024
@rustbot rustbot added I-prioritize Issue: Indicates that prioritization has been requested for this issue. needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Mar 31, 2024
@fmease
Copy link
Member

fmease commented Mar 31, 2024

I, as the reviewer, did a crater run for this in the regressing PR #121545, found a single regression which was fixed by a contributor, and I deemed it okay to merge it as it's a correctness fix. I was fully aware that this was a breaking change.

Since an incredibly similar PR authored by myself, namely #104148, was merged without a (lang) FCP and only a crater run more than a year ago, I followed suit.

@fmease fmease removed I-prioritize Issue: Indicates that prioritization has been requested for this issue. needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Mar 31, 2024
@Mark-Simulacrum
Copy link
Member Author

Sounds good, that sounds fine to me. We'll mention this in release notes.

@fmease fmease added the A-attributes Area: Attributes (`#[…]`, `#![…]`) label Mar 31, 2024
@Mark-Simulacrum Mark-Simulacrum added regression-from-stable-to-stable Performance or correctness regression from one stable version to another. and removed regression-from-stable-to-beta Performance or correctness regression from stable to beta. labels Oct 11, 2024
@rustbot rustbot added the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Oct 11, 2024
@apiraino apiraino removed the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Oct 12, 2024
@apiraino
Copy link
Contributor

Closing since regression is mentioned in the release notes

@apiraino apiraino closed this as not planned Won't fix, can't repro, duplicate, stale Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-attributes Area: Attributes (`#[…]`, `#![…]`) regression-from-stable-to-stable Performance or correctness regression from one stable version to another. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

4 participants