Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several tests with //@ needs-force-clang-based-tests don't seem to run anywhere #126375

Open
Zalathar opened this issue Jun 13, 2024 · 1 comment
Labels
A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@Zalathar
Copy link
Contributor

Zalathar commented Jun 13, 2024

(Follow-up to #126180 and #126257.)

There are currently 5 tests that use the needs-force-clang-based-tests header (formerly needs-matching-clang):

  • tests/run-make/cross-lang-lto-clang/Makefile (this one does actually run)
  • tests/run-make/cross-lang-lto-pgo-smoketest/Makefile
  • tests/run-make/cross-lang-lto-riscv-abi/rmake.rs
  • tests/run-make/issue-84395-lto-embed-bitcode/Makefile
  • tests/run-make/wasm-override-linker/Makefile

Tests with this header only run when RUSTBUILD_FORCE_CLANG_BASED_TESTS is set. That environment variable is only set in the x86_64-gnu-debug job, and only when running x --stage 2 test tests/run-make --test-args clang. So in practice, 4/5 of the above tests don't appear to ever run in any CI job.

@rustbot label +A-testsuite

@rustbot rustbot added needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. A-testsuite Area: The testsuite used to check the correctness of rustc labels Jun 13, 2024
@Kobzol
Copy link
Contributor

Kobzol commented Jun 13, 2024

For completeness, this is the full list of run-make tests that are currently not being executed in any CI job, according to my CI scripts:

[run-make] tests/run-make/cross-lang-lto-pgo-smoketest
[run-make] tests/run-make/cross-lang-lto-riscv-abi
[run-make] tests/run-make/issue-84395-lto-embed-bitcode
[run-make] tests/run-make/wasm-exceptions-nostd
[run-make] tests/run-make/wasm-override-linker
[run-make] tests/run-make/windows-safeseh
[run-make] tests/run-make/x86_64-fortanix-unknown-sgx-lvi

@jieyouxu jieyouxu added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. C-bug Category: This is a bug. A-run-make Area: port run-make Makefiles to rmake.rs and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

4 participants