Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unstable error message order #128532

Open
folkertdev opened this issue Aug 2, 2024 · 0 comments
Open

unstable error message order #128532

folkertdev opened this issue Aug 2, 2024 · 0 comments
Labels
A-diagnostics Area: Messages for errors, warnings, and lints A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) C-bug Category: This is a bug. D-diagnostic-infra Diagnostics: Issues that affect all diagnostics, or relate to the diagnostic machinery itself. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@folkertdev
Copy link
Contributor

In #125558 we ran into inconsistent ordering of error messages between CI and our local machines.

Our fix was to re-order the top-level definitions, so that global_asm! comes before a function containing inline asm!.

Here the first commit failed on CI, the second one works. The only change is ordering of top-level definitions: 08c8887 .. 8fd7cc9

gist containing source files because idk how long force pushes are kept

@oli-obk had this theory

It's probably some code iterating over a hashmap and invoking queries as it does. Should be fairly easy to find as it must be in thr backtrace of the error (you can get that with -Ztreat-err-as-bug=index_of_the_error_in_the_output)

@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Aug 2, 2024
@jieyouxu jieyouxu added A-diagnostics Area: Messages for errors, warnings, and lints T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) D-diagnostic-infra Diagnostics: Issues that affect all diagnostics, or relate to the diagnostic machinery itself. C-bug Category: This is a bug. and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) C-bug Category: This is a bug. D-diagnostic-infra Diagnostics: Issues that affect all diagnostics, or relate to the diagnostic machinery itself. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

3 participants