Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagnostic doesn't mention cfg'ed out items if the unresolved path is simple (i.e., a single identifier) #132166

Open
fmease opened this issue Oct 26, 2024 · 0 comments
Labels
A-diagnostics Area: Messages for errors, warnings, and lints A-resolve Area: Name resolution D-terse Diagnostics: An error or lint that doesn't give enough information about the problem at hand. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@fmease
Copy link
Member

fmease commented Oct 26, 2024

Given the following code, I would've expected rustc to mention the cfg'ed out item Struct:

#[cfg(flag)]
struct Struct;

fn main() { let _ = Struct; } //~ ERROR cannot find type `Struct` in this scope

but it doesn't:

error[E0425]: cannot find value `Struct` in this scope
 --> file.rs:4:21
  |
4 | fn main() { let _ = Struct; }
  |                     ^^^^^^ not found in this scope

Only if you slightly tweak the input by replacing the simple path Struct with a complex one like self::Struct or crate::Struct, the note "found an item that was configured out" will show up:

#[cfg(flag)]
struct Struct;

fn main() { let _ = self::Struct; }
error[E0425]: cannot find value `Struct` in module `self`
 --> file.rs:4:27
  |
4 | fn main() { let _ = self::Struct; }
  |                           ^^^^^^ not found in `self`
  |
note: found an item that was configured out
 --> file.rs:2:8
  |
2 | struct Struct;
  |        ^^^^^^
note: the item is gated here
 --> file.rs:1:1
  |
1 | #[cfg(flag)]
  | ^^^^^^^^^^^^

CC #109005. I don't know if that's intentional or not.

@fmease fmease added A-diagnostics Area: Messages for errors, warnings, and lints A-resolve Area: Name resolution D-terse Diagnostics: An error or lint that doesn't give enough information about the problem at hand. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints A-resolve Area: Name resolution D-terse Diagnostics: An error or lint that doesn't give enough information about the problem at hand. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

1 participant