Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn when using slices which are unbounded below #19816

Closed
nrc opened this issue Dec 13, 2014 · 1 comment
Closed

Warn when using slices which are unbounded below #19816

nrc opened this issue Dec 13, 2014 · 1 comment

Comments

@nrc
Copy link
Member

nrc commented Dec 13, 2014

Because they might be removed (see RFC PR 498 for discussion). If we do decide to remove these slices, it would be nice to give users some warning, but if we wait for the RFC to be resolved, there will not be much time to do so. Therefore it might be a good idea to warn now that changes might happen (especially since implementation of the warning should be easy).

@aturon what do you think?
@nrc
Copy link
Member Author

nrc commented Dec 13, 2014

Discussed on irc: the slicing syntax is feature gated and all uses of slicing will break due to the removal of the implicit borrow. Plus fixing this is easy - just add 0. So, no need for a warning.

@nrc nrc closed this as completed Dec 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nrc