pub extern crate foo; doesn't work

[bvssvni]

pub extern crate foo;

vs

extern crate "foo" as foo_lib;
pub use foo_lib as foo;

The second version works with piston but the first one doesn't. Tested by overriding dependency locally with the image example in Piston.

cc @eddyb @Kimundi

[sfackler]

I thought we disallowed pub extern crate entirely?

[Kimundi]

See rust-lang/rfcs#385

[frewsxcv]

So should the pub actually have any effect? From my experiences this is still an issue (adding pub doesn't publicize the external crate)

[Kimundi]

It should have the effect of making the extern crate item externally reachable from the module.

[frewsxcv]

Oh, I guess that makes sense. I originally thought that adding a pub would make it visible outside the module in addition to inside.

It might be nice if there was a section in the docs about the pub prefix for extern crate

https://doc.rust-lang.org/stable/reference.html#extern-crate-declarations

[yberreby]

This just bit me, the pub should behave as expected or not compile.

[nrc]

dup of #26775