Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E0017 needs to be updated to new format #35195

Closed
sophiajt opened this issue Aug 2, 2016 · 0 comments
Closed

E0017 needs to be updated to new format #35195

sophiajt opened this issue Aug 2, 2016 · 0 comments
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.

Comments

@sophiajt
Copy link
Contributor

sophiajt commented Aug 2, 2016

From: src/test/compile-fail/E0017.rs

E0017 needs a span_label to be added, taking the examples from:

error[E0017]: references in constants may only refer to immutable values
  --> src/test/compile-fail/E0017.rs:14:30
   |
14 | const CR: &'static mut i32 = &mut C; //~ ERROR E0017
   |                              ^^^^^^

to:

error[E0017]: references in constants may only refer to immutable values
  --> src/test/compile-fail/E0017.rs:14:30
   |
14 | const CR: &'static mut i32 = &mut C; //~ ERROR E0017
   |                              ^^^^^^ constants require immutable values

Bonus: you'll notice this test file duplicates its error messages. Ideally, each error would be printed only once.

@sophiajt sophiajt added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. A-diagnostics Area: Messages for errors, warnings, and lints E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. and removed E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. labels Aug 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
Projects
None yet
Development

No branches or pull requests

1 participant