Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E0117 needs to be updated to new format #35250

Closed
sophiajt opened this issue Aug 3, 2016 · 1 comment
Closed

E0117 needs to be updated to new format #35250

sophiajt opened this issue Aug 3, 2016 · 1 comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.

Comments

@sophiajt
Copy link
Contributor

sophiajt commented Aug 3, 2016

From: src/test/compile-fail/E0117.rs

Error E0117 needs a span_label, updated error text, and a note, updating it from:

error[E0117]: the impl does not reference any types defined in this crate; only traits defined in the current crate can be implemented for arbitrary types
  --> src/test/compile-fail/E0117.rs:11:1
   |
11 | impl Drop for u32 {} //~ ERROR E0117
   | ^^^^^^^^^^^^^^^^^^^^

to:

error[E0117]: only traits defined in the current crate can be implemented for arbitrary types
  --> src/test/compile-fail/E0117.rs:11:1
   |
11 | impl Drop for u32 {} //~ ERROR E0117
   | ^^^^^^^^^^^^^^^^^^^^ impl doesn't use types inside crate
   |
   = note: the impl does not reference any types defined in this crate
@sophiajt sophiajt added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. A-diagnostics Area: Messages for errors, warnings, and lints E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. labels Aug 3, 2016
@Detegr
Copy link
Contributor

Detegr commented Aug 4, 2016

In case no one is working with this yet, I can give this a go.

@bors bors closed this as completed in ac10b5f Aug 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
Projects
None yet
Development

No branches or pull requests

2 participants