Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

building compiler docs fails #36533

Closed
llogiq opened this issue Sep 16, 2016 · 6 comments
Closed

building compiler docs fails #36533

llogiq opened this issue Sep 16, 2016 · 6 comments

Comments

@llogiq
Copy link
Contributor

llogiq commented Sep 16, 2016

Steps taken:

$ git clone https://github.com/rust-lang/rust &&\
cd rust && ./configure --enabled compiler idols &&\
make docs

Expected result:

Full docs including compiler docs in doc/ subdirectory

Actual result:

make fails during doc/rustc_built-in/index.html, rustdoc error: Unrecognized option: 'l'.

@TimNN TimNN added the A-build label Sep 16, 2016
@hanna-kruppe
Copy link
Contributor

Again? #36031 was only fixed 11 days ago 😢 I second this motion by @retep998 in the last issue:

Might be worth having --enable-compiler-docs on some of the buildbots.

@llogiq
Copy link
Contributor Author

llogiq commented Sep 16, 2016

I third @retep998's motion. At least one should have it.

@ollie27
Copy link
Member

ollie27 commented Sep 18, 2016

It looks like this was caused by #35021 (cc @japaric). It's trying to pass -lstatic=compiler-rt to rustdoc when compiling the docs for compiler_builtins but rustdoc doesn't support -l.

@stefanhusmann
Copy link

How can this be fixed? Alternativly, how can I suppress the build of docs?

@Manishearth
Copy link
Member

Manishearth commented Nov 2, 2016

./configure --disable-compiler-docs . It's off by default.

I use

diff --git a/mk/crates.mk b/mk/crates.mk
index c7abf27..f68fc2a 100644
--- a/mk/crates.mk
+++ b/mk/crates.mk
@@ -78,7 +78,6 @@ DEPS_panic_abort := libc alloc
 DEPS_panic_unwind := libc alloc unwind
 DEPS_unwind := libc

-RUSTFLAGS_compiler_builtins := -lstatic=compiler-rt

 # FIXME(stage0): change this to just `RUSTFLAGS_panic_abort := ...`
 RUSTFLAGS1_panic_abort := -C panic=abort

on my builds to get the compiler doc build to pass

@ollie27
Copy link
Member

ollie27 commented Mar 27, 2017

This can be closed now. It was a bug in the long gone Makefiles. The compiler docs now build fine with rustbuild, or at least did and will again after #40852.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants