Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reachable symbols should be determined by the MIR #36594

Closed
Aatch opened this issue Sep 20, 2016 · 7 comments
Closed

Reachable symbols should be determined by the MIR #36594

Aatch opened this issue Sep 20, 2016 · 7 comments
Labels
A-linkage Area: linking into static, shared libraries and binaries A-MIR Area: Mid-level IR (MIR) - https://blog.rust-lang.org/2016/04/19/MIR.html C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@Aatch
Copy link
Contributor

Aatch commented Sep 20, 2016

Currently, the set of reachable symbols is determined by the privacy, and whether or a function that references the symbol could be inlined cross-crate. With MIR inlining (see #36593), symbols that were previously considered unreachable from outside the crate may become reachable if an item that isn't inlined cross-crate is inlined into another function that is inlined cross-crate.
@Aatch Aatch added the A-MIR Area: Mid-level IR (MIR) - https://blog.rust-lang.org/2016/04/19/MIR.html label Sep 20, 2016
@jonas-schievink
Copy link
Contributor

jonas-schievink commented Sep 20, 2016 •
edited
Loading

This looks like it would fix #35870, too

EDIT: Not inherently, at least

@Mark-Simulacrum Mark-Simulacrum added the C-enhancement Category: An issue proposing an enhancement or a PR with one. label Jul 26, 2017
@steveklabnik
Copy link
Member

Triage: no idea what the situation is with this bug, honestly.

@jonas-schievink jonas-schievink added A-linkage Area: linking into static, shared libraries and binaries T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 9, 2020
@eddyb
Copy link
Member

eddyb commented Jan 16, 2020

cc @michaelwoerister @Zoxc @oli-obk

@oli-obk
Copy link
Contributor

oli-obk commented Jan 17, 2020

cc @wesleywiser

@bjorn3
Copy link
Member

bjorn3 commented May 15, 2022

cc @cjgillot Do you think #91743 could make whatever this issue is about visible on stable? Or do you think this issue has been fixed since?

@cjgillot
Copy link
Contributor

I have no idea what this bug is about.

@oli-obk
Copy link
Contributor

oli-obk commented May 16, 2022

the monomorphization collector works completely on MIR nowadays. I think we fixed all these issues since they were occurring with return-position-impl-trait already.

@oli-obk oli-obk closed this as completed May 16, 2022
@tmiasko tmiasko mentioned this issue Jun 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-linkage Area: linking into static, shared libraries and binaries A-MIR Area: Mid-level IR (MIR) - https://blog.rust-lang.org/2016/04/19/MIR.html C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@steveklabnik @eddyb @oli-obk @Aatch @jonas-schievink @cjgillot @Mark-Simulacrum @bjorn3