Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust 1.18 regression - mime_multipart-0.3.5 #40958

Closed
alexcrichton opened this issue Mar 31, 2017 · 6 comments
Closed

Rust 1.18 regression - mime_multipart-0.3.5 #40958

alexcrichton opened this issue Mar 31, 2017 · 6 comments
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@alexcrichton
Copy link
Member

Regression logs

This looks like a soundness fix, but this'll track ensuring we send a PR upstream and file this into the release notes.

@alexcrichton alexcrichton added the regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. label Mar 31, 2017
@brson brson added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Apr 4, 2017
@alexcrichton
Copy link
Member Author

commit b118d606feb62c15d0dbd4e3280597a02e004190
Author: Mike Dilger <[email protected]>
Date:   Wed Dec 14 11:49:41 2016 +1300

    0.3.5

https://github.com/mikedilger/mime-multipart

@alexcrichton alexcrichton reopened this Apr 4, 2017
@alexcrichton alexcrichton added regression-from-stable-to-beta Performance or correctness regression from stable to beta. and removed regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. labels Apr 4, 2017
@alexcrichton
Copy link
Member Author

Code in question

@arielb1
Copy link
Contributor

arielb1 commented Apr 4, 2017

Signature of parse_headers:

pub fn parse_headers<'b: 'h, 'h>(src: &'b [u8], mut dst: &'h mut [Header<'b>])

This was caused by #40319 and indeed discussed in the thread with the author: #40319 (comment).

@nikomatsakis
Copy link
Contributor

OK, closing this issue then.

@nikomatsakis
Copy link
Contributor

@mikedilger you may wish to publish the new versions of the crate, if you've not already done so.

@mikedilger
Copy link
Contributor

@nikomatsakis New versions were published 9th of March. I hope 0.3.5 doesn't get pulled into regression testing of each subsequent rust version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

5 participants