Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

carboxyl_time-0.0.2 beta regression #43658

Closed
est31 opened this issue Aug 5, 2017 · 9 comments
Closed

carboxyl_time-0.0.2 beta regression #43658

est31 opened this issue Aug 5, 2017 · 9 comments
Labels
C-bug Category: This is a bug. regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@est31
Copy link
Member

est31 commented Aug 5, 2017

carboxyl_time version 0.0.2 regressed from stable to beta (full log):

 error: type `signal::FuncSignal<A>` is private
   --> /cargo-home/registry/src/github.com-1ecc6299db9ec823/carboxyl-0.1.2/src/lift.rs:80:28
    |
 80 |             SignalFn::Func(_) => SignalFn::from_fn(move || f(sample_raw(&pclone))),
    |                            ^
 
@est31
Copy link
Member Author

est31 commented Aug 5, 2017

cc @aepsil0n

@petrochenkov
Copy link
Contributor

This is a known regression (see #42125 (comment)).
The issue was actually in carboxyl, not carboxyl_time, and it was fixed in Feb 2016, but carboxyl_time still uses outdated version of carboxyl.

@arielb1 arielb1 added regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 5, 2017
@milibopp
Copy link
Contributor

milibopp commented Aug 5, 2017

Ah, this is actually fixed on master and the tagged 0.0.3 version, but I think it has not been published yet to crates.io. Let me do that right away.

@milibopp
Copy link
Contributor

milibopp commented Aug 5, 2017

Uhm… okay, this is a bit unfortunate, but I am blocked on rust-lang/cargo#4264. Now I remember why I did not publish this in the first place: same issue, but I did not have time to look into it and forgot about later.

@Mark-Simulacrum Mark-Simulacrum added the C-bug Category: This is a bug. label Aug 10, 2017
@alexcrichton
Copy link
Member

@aepsil0n an issue like rust-lang/cargo#4264 is pretty unlikely to be indicative of a bug in Cargo, are you sure this happens persistently over time? If so would you able to help debug that issue?

@milibopp
Copy link
Contributor

It does happen persistently at least on my machine. (Tried it for the third time now.) I am glad to help out with debugging, if you can tell me what to look for. Meanwhile I should probably try this on another machine.

@alexcrichton
Copy link
Member

Hm could you try to attach a debugger when Cargo looks like it hanging and see what the backtrace is? Also, can you try setting RUST_LOG=debug and see if Cargo prints anything useful to know where it's publishing to?

@milibopp
Copy link
Contributor

Uhm, that's weird… I just tried publishing at work and it went fine. I'm starting to suspect that my wifi network at home has an issue. Need to look into this further.

Anyway, the regression should be fixed now.

@alexcrichton
Copy link
Member

Thanks @aepsil0n!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug. regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

6 participants