Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustbuild --keep-stage 0 still rebuilds everything #44737

Closed
arielb1 opened this issue Sep 21, 2017 · 3 comments
Closed

rustbuild --keep-stage 0 still rebuilds everything #44737

arielb1 opened this issue Sep 21, 2017 · 3 comments
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@arielb1
Copy link
Contributor

arielb1 commented Sep 21, 2017

Meta

Found to occur in commit e2504cf (Sep 21)

Description

config.toml content:

$ sed -r -e 's/^#.*$//' -e '/^$/d' config.toml
[llvm]
ccache = true
[build]
[install]
[rust]
debuginfo-lines = true
[target.x86_64-unknown-linux-gnu]
[dist]
$ echo 'FIRST BUILD' ; ../x.py build ; echo 'SECOND BUILD' ; ../x.py build --keep-stage 0 ; touch ../src/librustc/lib.rs ; echo 'THIRD BUILD'; ../x.py build --keep-stage 0
FIRST BUILD
Updating submodules
error: could not lock config file /home/ariel/Rust/rust/.git/modules/src/liblibc/config: File exists
    Finished dev [unoptimized] target(s) in 0.0 secs
Building stage0 std artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
    Finished release [optimized] target(s) in 0.0 secs
Copying stage0 std from stage0 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
Building stage0 test artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
    Finished release [optimized] target(s) in 0.0 secs
Copying stage0 test from stage0 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
Building stage0 compiler artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
   Compiling rustc_metadata v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_metadata)
   Compiling rustc_save_analysis v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_save_analysis)
   Compiling rustc_mir v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_mir)
   Compiling rustc_trans v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_trans)
   Compiling rustc_borrowck v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_borrowck)
   Compiling rustc_plugin v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_plugin)
   Compiling rustc_driver v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_driver)
   Compiling rustc-main v0.0.0 (file:///home/ariel/Rust/rust/src/rustc)
    Finished release [optimized] target(s) in 263.68 secs
Copying stage0 rustc from stage0 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
Assembling stage1 compiler (x86_64-unknown-linux-gnu)
Building stage1 std artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
   Compiling core v0.0.0 (file:///home/ariel/Rust/rust/src/libcore)
   Compiling unwind v0.0.0 (file:///home/ariel/Rust/rust/src/libunwind)
   Compiling libc v0.0.0 (file:///home/ariel/Rust/rust/src/rustc/libc_shim)
   Compiling compiler_builtins v0.0.0 (file:///home/ariel/Rust/rust/src/rustc/compiler_builtins_shim)
   Compiling rustc_msan v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_msan)
   Compiling rustc_lsan v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_lsan)
   Compiling alloc_jemalloc v0.0.0 (file:///home/ariel/Rust/rust/src/liballoc_jemalloc)
   Compiling rustc_tsan v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_tsan)
   Compiling rustc_asan v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_asan)
   Compiling std v0.0.0 (file:///home/ariel/Rust/rust/src/libstd)
   Compiling rand v0.0.0 (file:///home/ariel/Rust/rust/src/librand)
   Compiling std_unicode v0.0.0 (file:///home/ariel/Rust/rust/src/libstd_unicode)
   Compiling panic_abort v0.0.0 (file:///home/ariel/Rust/rust/src/libpanic_abort)
   Compiling alloc v0.0.0 (file:///home/ariel/Rust/rust/src/liballoc)
   Compiling panic_unwind v0.0.0 (file:///home/ariel/Rust/rust/src/libpanic_unwind)
   Compiling collections v0.0.0 (file:///home/ariel/Rust/rust/src/libcollections)
   Compiling alloc_system v0.0.0 (file:///home/ariel/Rust/rust/src/liballoc_system)
    Finished release [optimized] target(s) in 41.73 secs
Copying stage1 std from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
Building stage1 test artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
   Compiling term v0.0.0 (file:///home/ariel/Rust/rust/src/libterm)
   Compiling getopts v0.2.14
   Compiling test v0.0.0 (file:///home/ariel/Rust/rust/src/libtest)
    Finished release [optimized] target(s) in 13.62 secs
Copying stage1 test from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
Building stage1 compiler artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
   Compiling arena v0.0.0 (file:///home/ariel/Rust/rust/src/libarena)
   Compiling libc v0.2.30
   Compiling rustc-serialize v0.3.24
   Compiling bitflags v1.0.0
   Compiling ar v0.3.0
   Compiling log v0.3.8
   Compiling graphviz v0.0.0 (file:///home/ariel/Rust/rust/src/libgraphviz)
   Compiling rustc-demangle v0.1.5
   Compiling rustc_platform_intrinsics v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_platform_intrinsics)
   Compiling serialize v0.0.0 (file:///home/ariel/Rust/rust/src/libserialize)
   Compiling stable_deref_trait v1.0.0
   Compiling fmt_macros v0.0.0 (file:///home/ariel/Rust/rust/src/libfmt_macros)
   Compiling rustc_trans v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_trans)
   Compiling rustc v0.0.0 (file:///home/ariel/Rust/rust/src/librustc)
   Compiling rustc_driver v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_driver)
   Compiling rustc_cratesio_shim v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_cratesio_shim)
   Compiling rustc_metadata v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_metadata)
   Compiling jobserver v0.1.6
   Compiling num_cpus v1.6.2
   Compiling env_logger v0.4.3
   Compiling rustc_back v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_back)
   Compiling syntax v0.0.0 (file:///home/ariel/Rust/rust/src/libsyntax)
   Compiling owning_ref v0.3.3
   Compiling rustc_incremental v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_incremental)
   Compiling rustc_apfloat v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_apfloat)
   Compiling rustc_data_structures v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_data_structures)
   Compiling miniz-sys v0.1.9
   Compiling rls-span v0.4.0
   Compiling rustc_llvm v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_llvm)
   Compiling syntax_pos v0.0.0 (file:///home/ariel/Rust/rust/src/libsyntax_pos)
   Compiling rls-data v0.10.0
   Compiling flate2 v0.2.19
   Compiling rustc_errors v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_errors)
   Compiling proc_macro v0.0.0 (file:///home/ariel/Rust/rust/src/libproc_macro)
   Compiling rustc_const_math v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_const_math)
   Compiling syntax_ext v0.0.0 (file:///home/ariel/Rust/rust/src/libsyntax_ext)
   Compiling rustc_resolve v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_resolve)
   Compiling rustc_const_eval v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_const_eval)
   Compiling rustc_privacy v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_privacy)
   Compiling rustc_typeck v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_typeck)
   Compiling rustc_trans_utils v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_trans_utils)
   Compiling rustc_allocator v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_allocator)
   Compiling rustc_lint v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_lint)
   Compiling rustc_mir v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_mir)
   Compiling rustc_passes v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_passes)
   Compiling rustc_save_analysis v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_save_analysis)
   Compiling rustc_plugin v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_plugin)
   Compiling rustc_borrowck v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_borrowck)
   Compiling rustc-main v0.0.0 (file:///home/ariel/Rust/rust/src/rustc)
    Finished release [optimized] target(s) in 865.47 secs
Copying stage1 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
Assembling stage2 compiler (x86_64-unknown-linux-gnu)
Uplifting stage1 std (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
Copying stage2 std from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
Uplifting stage1 test (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
Copying stage2 test from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
Building rustdoc for stage2 (x86_64-unknown-linux-gnu)
    Finished release [optimized] target(s) in 0.0 secs
Build completed successfully in 0:19:50

    \--- COMMENT MINE: OK, BUILDS EVERYTHING

SECOND BUILD
Updating submodules
error: could not lock config file /home/ariel/Rust/rust/.git/modules/src/liblibc/config: File exists
    Finished dev [unoptimized] target(s) in 0.0 secs
Building stage0 std artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
    Finished release [optimized] target(s) in 0.0 secs
Copying stage0 std from stage0 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
Building stage0 test artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
    Finished release [optimized] target(s) in 0.0 secs
Copying stage0 test from stage0 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
Building stage0 compiler artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
    Finished release [optimized] target(s) in 0.0 secs
Copying stage0 rustc from stage0 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
Assembling stage1 compiler (x86_64-unknown-linux-gnu)
Building stage1 std artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
    Finished release [optimized] target(s) in 0.0 secs
Copying stage1 std from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
Building stage1 test artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
    Finished release [optimized] target(s) in 0.0 secs
Copying stage1 test from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
Building stage1 compiler artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
    Finished release [optimized] target(s) in 0.0 secs
Copying stage1 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
Assembling stage2 compiler (x86_64-unknown-linux-gnu)
Uplifting stage1 std (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
Copying stage2 std from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
Uplifting stage1 test (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
Copying stage2 test from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
Building rustdoc for stage2 (x86_64-unknown-linux-gnu)
    Finished release [optimized] target(s) in 0.0 secs
Build completed successfully in 0:00:04

    \--- COMMENT MINE: OK, IDENTITY REBUILD
    \--- (touched librustc)

THIRD BUILD
Updating submodules
error: could not lock config file /home/ariel/Rust/rust/.git/modules/src/liblibc/config: File exists
    Finished dev [unoptimized] target(s) in 0.0 secs
Building stage0 std artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
    Finished release [optimized] target(s) in 0.0 secs
Copying stage0 std from stage0 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
Building stage0 test artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
    Finished release [optimized] target(s) in 0.0 secs
Copying stage0 test from stage0 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
Building stage0 compiler artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
   Compiling rustc v0.0.0 (file:///home/ariel/Rust/rust/src/librustc)
   Compiling rustc_allocator v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_allocator)
   Compiling rustc_resolve v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_resolve)
   Compiling rustc_trans_utils v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_trans_utils)
   Compiling rustc_metadata v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_metadata)
   Compiling rustc_const_eval v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_const_eval)
   Compiling rustc_typeck v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_typeck)
   Compiling rustc_privacy v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_privacy)
   Compiling rustc_incremental v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_incremental)
   Compiling rustc_lint v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_lint)
   Compiling rustc_mir v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_mir)
   Compiling rustc_passes v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_passes)
   Compiling rustc_trans v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_trans)
   Compiling rustc_save_analysis v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_save_analysis)
   Compiling rustc_plugin v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_plugin)
   Compiling rustc_borrowck v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_borrowck)
   Compiling rustc_driver v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_driver)
   Compiling rustc-main v0.0.0 (file:///home/ariel/Rust/rust/src/rustc)
    Finished release [optimized] target(s) in 645.93 secs
Copying stage0 rustc from stage0 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
Assembling stage1 compiler (x86_64-unknown-linux-gnu)
Building stage1 std artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
   Compiling core v0.0.0 (file:///home/ariel/Rust/rust/src/libcore)
   Compiling libc v0.0.0 (file:///home/ariel/Rust/rust/src/rustc/libc_shim)
   Compiling unwind v0.0.0 (file:///home/ariel/Rust/rust/src/libunwind)
   Compiling compiler_builtins v0.0.0 (file:///home/ariel/Rust/rust/src/rustc/compiler_builtins_shim)
   Compiling rustc_lsan v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_lsan)
   Compiling rustc_asan v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_asan)
   Compiling rustc_msan v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_msan)
   Compiling alloc_jemalloc v0.0.0 (file:///home/ariel/Rust/rust/src/liballoc_jemalloc)
   Compiling rustc_tsan v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_tsan)
   Compiling std v0.0.0 (file:///home/ariel/Rust/rust/src/libstd)
   Compiling rand v0.0.0 (file:///home/ariel/Rust/rust/src/librand)
   Compiling std_unicode v0.0.0 (file:///home/ariel/Rust/rust/src/libstd_unicode)
   Compiling panic_abort v0.0.0 (file:///home/ariel/Rust/rust/src/libpanic_abort)
   Compiling alloc v0.0.0 (file:///home/ariel/Rust/rust/src/liballoc)
   Compiling alloc_system v0.0.0 (file:///home/ariel/Rust/rust/src/liballoc_system)
   Compiling panic_unwind v0.0.0 (file:///home/ariel/Rust/rust/src/libpanic_unwind)
   Compiling collections v0.0.0 (file:///home/ariel/Rust/rust/src/libcollections)
    Finished release [optimized] target(s) in 40.96 secs
Copying stage1 std from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
Building stage1 test artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
   Compiling getopts v0.2.14
   Compiling term v0.0.0 (file:///home/ariel/Rust/rust/src/libterm)
   Compiling test v0.0.0 (file:///home/ariel/Rust/rust/src/libtest)
    Finished release [optimized] target(s) in 13.54 secs
Copying stage1 test from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
Building stage1 compiler artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
   Compiling graphviz v0.0.0 (file:///home/ariel/Rust/rust/src/libgraphviz)
   Compiling ar v0.3.0
   Compiling arena v0.0.0 (file:///home/ariel/Rust/rust/src/libarena)
   Compiling rustc-demangle v0.1.5
   Compiling libc v0.2.30
   Compiling fmt_macros v0.0.0 (file:///home/ariel/Rust/rust/src/libfmt_macros)
   Compiling rustc_platform_intrinsics v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_platform_intrinsics)
   Compiling log v0.3.8
   Compiling serialize v0.0.0 (file:///home/ariel/Rust/rust/src/libserialize)
   Compiling bitflags v1.0.0
   Compiling rustc-serialize v0.3.24
   Compiling stable_deref_trait v1.0.0
   Compiling rustc v0.0.0 (file:///home/ariel/Rust/rust/src/librustc)
   Compiling rustc_back v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_back)
   Compiling syntax v0.0.0 (file:///home/ariel/Rust/rust/src/libsyntax)
   Compiling rustc_driver v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_driver)
   Compiling rustc_incremental v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_incremental)
   Compiling rustc_trans v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_trans)
   Compiling jobserver v0.1.6
   Compiling num_cpus v1.6.2
   Compiling rustc_metadata v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_metadata)
   Compiling env_logger v0.4.3
   Compiling rustc_cratesio_shim v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_cratesio_shim)
   Compiling owning_ref v0.3.3
   Compiling miniz-sys v0.1.9
   Compiling rustc_apfloat v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_apfloat)
   Compiling rustc_data_structures v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_data_structures)
   Compiling rustc_llvm v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_llvm)
   Compiling flate2 v0.2.19
   Compiling rls-span v0.4.0
   Compiling syntax_pos v0.0.0 (file:///home/ariel/Rust/rust/src/libsyntax_pos)
   Compiling rls-data v0.10.0
   Compiling rustc_errors v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_errors)
   Compiling rustc_const_math v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_const_math)
   Compiling proc_macro v0.0.0 (file:///home/ariel/Rust/rust/src/libproc_macro)
   Compiling syntax_ext v0.0.0 (file:///home/ariel/Rust/rust/src/libsyntax_ext)
   Compiling rustc_resolve v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_resolve)
   Compiling rustc_typeck v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_typeck)
   Compiling rustc_const_eval v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_const_eval)
   Compiling rustc_allocator v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_allocator)
   Compiling rustc_trans_utils v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_trans_utils)
   Compiling rustc_privacy v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_privacy)
   Compiling rustc_mir v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_mir)
   Compiling rustc_passes v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_passes)
   Compiling rustc_lint v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_lint)
   Compiling rustc_save_analysis v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_save_analysis)
   Compiling rustc_plugin v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_plugin)
   Compiling rustc_borrowck v0.0.0 (file:///home/ariel/Rust/rust/src/librustc_borrowck)
   Compiling rustc-main v0.0.0 (file:///home/ariel/Rust/rust/src/rustc)
    Finished release [optimized] target(s) in 900.12 secs
Copying stage1 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
Assembling stage2 compiler (x86_64-unknown-linux-gnu)
Uplifting stage1 std (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
Copying stage2 std from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
Uplifting stage1 test (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
Copying stage2 test from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
Building rustdoc for stage2 (x86_64-unknown-linux-gnu)
    Finished release [optimized] target(s) in 0.0 secs
Build completed successfully in 0:26:44

    \-- COMMENT MINE: Would have expected only stage2 to be compiled from rustc onwards, but actually we compiled the entire world.
@arielb1 arielb1 added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) WG-infra-rustbuild labels Sep 21, 2017
@arielb1 arielb1 changed the title rustbuild --keep-stage 0 doesn't actually work rustbuild --keep-stage 0 still rebuilds everything Sep 21, 2017
@arielb1
Copy link
Contributor Author

arielb1 commented Sep 21, 2017

cc @Mark-Simulacrum

@jyn514
Copy link
Member

jyn514 commented Jan 1, 2021

@arielb1 are you still running into this? --keep-stage works fine for me.

@jyn514
Copy link
Member

jyn514 commented Jun 27, 2022

I'm going to close this since I haven't heard back - it should be less necessary to use --keep-stage 0 now that we recommend stage 1 builds anyway. I use --keep-stage-std 1 quite frequently and that works fine.

@jyn514 jyn514 closed this as not planned Won't fix, can't repro, duplicate, stale Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

No branches or pull requests

4 participants