Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: Masked functions still appear in the search result. #44740

Closed
kennytm opened this issue Sep 21, 2017 · 2 comments
Closed

rustdoc: Masked functions still appear in the search result. #44740

kennytm opened this issue Sep 21, 2017 · 2 comments
Labels
C-bug Category: This is a bug. T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@kennytm
Copy link
Member

kennytm commented Sep 21, 2017

Repro:

  1. Go to nightly docs
  2. Search for "aborting" (or just go to https://doc.rust-lang.org/nightly/std/?search=aborting)
  3. Note that the functions aborting_div and aborting_rem appeared.
  4. Clicking into the result will not jump to any functions.

Expected: aborting_div and aborting_rem should not appear in the search result.

The aborting_div and aborting_rem methods are part of the Int trait in compiler_builtins which is not supposed to be exposed. The documentation about this trait is successfully hidden thanks to #44026, but the search entry still exists.

cc @QuietMisdreavus

@aidanhs aidanhs added the C-bug Category: This is a bug. label Sep 21, 2017
@QuietMisdreavus QuietMisdreavus added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue. labels Sep 24, 2017
@GuillaumeGomez
Copy link
Member

Taking a look.

@GuillaumeGomez
Copy link
Member

Hum, I thought a check was missing but it doesn't seem to be the case, will require a deeper look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug. T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

4 participants