Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking issue for implementing stack probe correctly #49355

Closed
4 tasks
ishitatsuyuki opened this issue Mar 25, 2018 · 1 comment
Closed
4 tasks

Tracking issue for implementing stack probe correctly #49355

ishitatsuyuki opened this issue Mar 25, 2018 · 1 comment
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows A-stack-probe Area: Stack probing and guard pages C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. Libs-Tracked Libs issues that are tracked on the team's project board. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@ishitatsuyuki
Copy link
Contributor

ishitatsuyuki commented Mar 25, 2018 •
edited by tmandry
Loading

Stack guards are hard because it's different on every platform. OpenJDK has a few kLOCs dedicated to correctly probing stack. Our detection is far from perfect, and we probably can use JVM's code as a reference documentation for all the Unixes.

Issues on widely used platforms:

Possibly related:

Others:
@ishitatsuyuki ishitatsuyuki added the C-bug Category: This is a bug. label Mar 25, 2018
@jacobrosenthal jacobrosenthal mentioned this issue Sep 13, 2019
Closed
@jonas-schievink jonas-schievink added A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed C-bug Category: This is a bug. labels Apr 20, 2020
@mbrubeck mbrubeck mentioned this issue Jul 17, 2020
Merged
@KodrAus KodrAus added the Libs-Tracked Libs issues that are tracked on the team's project board. label Jul 29, 2020
@yaahc
Copy link
Member

yaahc commented Jun 1, 2022

we reviewed this issue during todays libs-api meeting and determined that this tracking issue is effectively serving the same role as a label, and that we'd prefer to use a label for this, so I've gone ahead and introduced the A-stack-probe label and applied it to all the referenced issues

@yaahc yaahc closed this as completed Jun 1, 2022
@yaahc yaahc added the A-stack-probe Area: Stack probing and guard pages label Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows A-stack-probe Area: Stack probing and guard pages C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. Libs-Tracked Libs issues that are tracked on the team's project board. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jonas-schievink @yaahc @KodrAus @ishitatsuyuki