Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rls no longer builds after rust-lang/rust#59227 #59902

Closed
rust-highfive opened this issue Apr 12, 2019 · 2 comments
Closed

rls no longer builds after rust-lang/rust#59227 #59902

rust-highfive opened this issue Apr 12, 2019 · 2 comments
Assignees
@Zoxc @nrc @Xanewok
Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@rust-highfive
Copy link
Collaborator

Hello, this is your friendly neighborhood mergebot.
After merging PR #59227, I observed that the tool rls no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/rls is needed to fix the fallout.

cc @Zoxc, do you think you would have time to do the follow-up work?
If so, that would be great!

cc @eddyb, the PR reviewer, and @rust-lang/compiler -- nominating for prioritization.
@rust-highfive rust-highfive added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 12, 2019
@Xanewok
Copy link
Member

Xanewok commented Apr 12, 2019

Probably caused by Clippy breakage, will bump to rust-lang/rust-clippy#3945 once it's merged.

@Xanewok
Copy link
Member

Xanewok commented Apr 14, 2019

This one has been fixed already, in the meantime a new issue popped up: #59970

@Xanewok Xanewok closed this as completed Apr 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Zoxc Zoxc

@nrc nrc

@Xanewok Xanewok

Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Zoxc @nrc @Xanewok @rust-highfive