Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustfmt no longer builds after rust-lang/rust#64172 #64180

Closed
rust-highfive opened this issue Sep 5, 2019 · 1 comment · Fixed by #64279
Closed

rustfmt no longer builds after rust-lang/rust#64172 #64180

rust-highfive opened this issue Sep 5, 2019 · 1 comment · Fixed by #64279
Assignees
@topecongiro
Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@rust-highfive
Copy link
Collaborator

Hello, this is your friendly neighborhood mergebot.
After merging PR #64172, I observed that the tool rustfmt no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/rustfmt is needed to fix the fallout.

cc @Centril, do you think you would have time to do the follow-up work?
If so, that would be great!

cc @Centril, the PR reviewer, and @rust-lang/compiler -- nominating for prioritization.
@rust-highfive rust-highfive added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 5, 2019
This was referenced Sep 5, 2019
Closed
Merged
@topecongiro
Copy link
Contributor

topecongiro commented Sep 6, 2019 •
edited by Xanewok
Loading

  • Release rustfmt 1.4.7 which fixes the build failure
  • Update racer to use rustc-ap-syntax 581.0.0 (Update rustc-ap-syntax to 581.0.0 racer-rust/racer#1071). We also need a new release of racer which includes the fix
  • Update rls to use racer and rustfmt which depend on rustc-ap-* 581.0.0

This was referenced Sep 7, 2019
Merged
Merged
@bors bors closed this as completed in f353d49 Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@topecongiro topecongiro

Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump RLS and Rustfmt submodules to use rustc-ap-* v583 Xanewok/rust
2 participants
@rust-highfive @topecongiro