Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid re-parsing with parse_in_attr #66940

Closed
Centril opened this issue Dec 1, 2019 · 0 comments · Fixed by #67052
Closed

Avoid re-parsing with parse_in_attr #66940

Centril opened this issue Dec 1, 2019 · 0 comments · Fixed by #67052
Assignees
@Centril @petrochenkov
Labels
A-attributes Area: Attributes (`#[…]`, `#![…]`) A-parser Area: The parsing of Rust source code to an AST C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@Centril
Copy link
Contributor

Centril commented Dec 1, 2019

See https://doc.rust-lang.org/nightly/nightly-rustc/rustc_parse/fn.parse_in_attr.html.
Leaving this as a FIXME issue.
@Centril Centril added C-cleanup Category: PRs that clean code up or issues documenting cleanup. A-attributes Area: Attributes (`#[…]`, `#![…]`) A-parser Area: The parsing of Rust source code to an AST T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 1, 2019
@Centril Centril mentioned this issue Dec 5, 2019
Merged
@bors bors closed this as completed in 941c4cd Dec 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Centril Centril

@petrochenkov petrochenkov

Labels
A-attributes Area: Attributes (`#[…]`, `#![…]`) A-parser Area: The parsing of Rust source code to an AST C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ditch parse_in_attr Centril/rust
2 participants
@Centril @petrochenkov