Unexpected trait resolution overflow error

[weiznich]

Trying to compile wundergraph_example with recent nightly's or the current beta ( rustc 1.46.0-beta.2 (6f959902b 2020-07-23) compiler fails with the attached error message. The compilation suceeds without warning using the latest stable (rustc 1.45.0 (5c1f21c3b 2020-07-13)) release.

Error message

error[E0275]: overflow evaluating the requirement `<<Hero_table as diesel::query_builder::AsQuery>::Query as diesel::query_dsl::boxed_dsl::BoxedDsl<'_, DB>>::Output`
  --> wundergraph_example/src/mutations.rs:73:1
   |
73 | / wundergraph::mutation_object! {
74 | |     /// Global mutation object for the schema
75 | |     Mutation {
76 | |         Hero(insert = NewHero, update = HeroChangeset,),
...  |
81 | |     }
82 | | }
   | |_^
   |
   = note: required because of the requirements on the impl of `wundergraph::query_builder::mutations::HandleUpdate<hero::Hero, mutations::HeroChangeset, DB, Ctx>` for `Hero_table`
   = note: required because of the requirements on the impl of `juniper::GraphQLType<wundergraph::scalar::WundergraphScalarValue>` for `mutations::Mutation<Ctx>`
   = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)

error[E0275]: overflow evaluating the requirement `<<Hero_table as diesel::query_builder::AsQuery>::Query as diesel::query_dsl::boxed_dsl::BoxedDsl<'_, DB>>::Output`
  --> wundergraph_example/src/mutations.rs:73:1
   |
73 | / wundergraph::mutation_object! {
74 | |     /// Global mutation object for the schema
75 | |     Mutation {
76 | |         Hero(insert = NewHero, update = HeroChangeset,),
...  |
81 | |     }
82 | | }
   | |_^
   |
   = note: required because of the requirements on the impl of `wundergraph::query_builder::mutations::HandleUpdate<hero::Hero, mutations::HeroChangeset, DB, Ctx>` for `Hero_table`
   = note: required because of the requirements on the impl of `juniper::GraphQLType<wundergraph::scalar::WundergraphScalarValue>` for `mutations::Mutation_wrapper<'a, Ctx>`
   = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)

error[E0275]: overflow evaluating the requirement `<<Hero_table as diesel::query_builder::AsQuery>::Query as diesel::query_dsl::boxed_dsl::BoxedDsl<'_, DB>>::Output`
  --> wundergraph_example/src/mutations.rs:73:1
   |
73 | / wundergraph::mutation_object! {
74 | |     /// Global mutation object for the schema
75 | |     Mutation {
76 | |         Hero(insert = NewHero, update = HeroChangeset,),
...  |
81 | |     }
82 | | }
   | |_^
   |
   = note: required because of the requirements on the impl of `wundergraph::query_builder::mutations::HandleUpdate<hero::Hero, mutations::HeroChangeset, DB, Ctx>` for `Hero_table`
   = note: required because of the requirements on the impl of `juniper::GraphQLType<wundergraph::scalar::WundergraphScalarValue>` for `mutations::Mutation_inner<'a, Ctx>`
   = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)

error[E0275]: overflow evaluating the requirement `<<Hero_table as diesel::query_builder::AsQuery>::Query as diesel::query_dsl::boxed_dsl::BoxedDsl<'_, DB>>::Output`
  --> wundergraph_example/src/mutations.rs:73:1
   |
73 | / wundergraph::mutation_object! {
74 | |     /// Global mutation object for the schema
75 | |     Mutation {
76 | |         Hero(insert = NewHero, update = HeroChangeset,),
...  |
81 | |     }
82 | | }
   | |_^
   |
   = note: required because of the requirements on the impl of `wundergraph::query_builder::mutations::HandleUpdate<hero::Hero, mutations::HeroChangeset, DB, Ctx>` for `Hero_table`
   = note: required because of the requirements on the impl of `juniper::GraphQLType<wundergraph::scalar::WundergraphScalarValue>` for `mutations::Mutation<Ctx>`
   = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)

error[E0275]: overflow evaluating the requirement `<<Hero_table as diesel::query_builder::AsQuery>::Query as diesel::query_dsl::boxed_dsl::BoxedDsl<'_, DB>>::Output`
  --> wundergraph_example/src/mutations.rs:73:1
   |
73 | / wundergraph::mutation_object! {
74 | |     /// Global mutation object for the schema
75 | |     Mutation {
76 | |         Hero(insert = NewHero, update = HeroChangeset,),
...  |
81 | |     }
82 | | }
   | |_^
   |
   = note: required because of the requirements on the impl of `wundergraph::query_builder::mutations::HandleUpdate<hero::Hero, mutations::HeroChangeset, DB, Ctx>` for `Hero_table`
   = note: required because of the requirements on the impl of `juniper::GraphQLType<wundergraph::scalar::WundergraphScalarValue>` for `mutations::Mutation<Ctx>`
   = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)

error[E0275]: overflow evaluating the requirement `<<Hero_table as diesel::query_builder::AsQuery>::Query as diesel::query_dsl::boxed_dsl::BoxedDsl<'_, DB>>::Output`
  --> wundergraph_example/src/mutations.rs:73:1
   |
73 | / wundergraph::mutation_object! {
74 | |     /// Global mutation object for the schema
75 | |     Mutation {
76 | |         Hero(insert = NewHero, update = HeroChangeset,),
...  |
81 | |     }
82 | | }
   | |_^
   |
   = note: required because of the requirements on the impl of `wundergraph::query_builder::mutations::HandleUpdate<hero::Hero, mutations::HeroChangeset, DB, Ctx>` for `Hero_table`
   = note: required because of the requirements on the impl of `juniper::GraphQLType<wundergraph::scalar::WundergraphScalarValue>` for `mutations::Mutation<Ctx>`
   = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)

error[E0275]: overflow evaluating the requirement `<<Hero_table as diesel::query_builder::AsQuery>::Query as diesel::query_dsl::boxed_dsl::BoxedDsl<'_, DB>>::Output`
  --> wundergraph_example/src/mutations.rs:73:1
   |
73 | / wundergraph::mutation_object! {
74 | |     /// Global mutation object for the schema
75 | |     Mutation {
76 | |         Hero(insert = NewHero, update = HeroChangeset,),
...  |
81 | |     }
82 | | }
   | |_^
   |
   = note: required because of the requirements on the impl of `wundergraph::query_builder::mutations::HandleUpdate<hero::Hero, mutations::HeroChangeset, DB, Ctx>` for `Hero_table`
   = note: required because of the requirements on the impl of `juniper::GraphQLType<wundergraph::scalar::WundergraphScalarValue>` for `mutations::Mutation_wrapper<'a, Ctx>`
   = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)

error[E0275]: overflow evaluating the requirement `<<Hero_table as diesel::query_builder::AsQuery>::Query as diesel::query_dsl::boxed_dsl::BoxedDsl<'_, DB>>::Output`
  --> wundergraph_example/src/mutations.rs:73:1
   |
73 | / wundergraph::mutation_object! {
74 | |     /// Global mutation object for the schema
75 | |     Mutation {
76 | |         Hero(insert = NewHero, update = HeroChangeset,),
...  |
81 | |     }
82 | | }
   | |_^
   |
   = note: required because of the requirements on the impl of `wundergraph::query_builder::mutations::HandleUpdate<hero::Hero, mutations::HeroChangeset, DB, Ctx>` for `Hero_table`
   = note: required because of the requirements on the impl of `juniper::GraphQLType<wundergraph::scalar::WundergraphScalarValue>` for `mutations::Mutation_wrapper<'a, Ctx>`
   = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)

error[E0275]: overflow evaluating the requirement `<<Hero_table as diesel::query_builder::AsQuery>::Query as diesel::query_dsl::boxed_dsl::BoxedDsl<'_, DB>>::Output`
  --> wundergraph_example/src/mutations.rs:73:1
   |
73 | / wundergraph::mutation_object! {
74 | |     /// Global mutation object for the schema
75 | |     Mutation {
76 | |         Hero(insert = NewHero, update = HeroChangeset,),
...  |
81 | |     }
82 | | }
   | |_^
   |
   = note: required because of the requirements on the impl of `wundergraph::query_builder::mutations::HandleUpdate<hero::Hero, mutations::HeroChangeset, DB, Ctx>` for `Hero_table`
   = note: required because of the requirements on the impl of `juniper::GraphQLType<wundergraph::scalar::WundergraphScalarValue>` for `mutations::Mutation_wrapper<'a, Ctx>`
   = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)

error[E0275]: overflow evaluating the requirement `<<Hero_table as diesel::query_builder::AsQuery>::Query as diesel::query_dsl::boxed_dsl::BoxedDsl<'_, DB>>::Output`
  --> wundergraph_example/src/mutations.rs:73:1
   |
73 | / wundergraph::mutation_object! {
74 | |     /// Global mutation object for the schema
75 | |     Mutation {
76 | |         Hero(insert = NewHero, update = HeroChangeset,),
...  |
81 | |     }
82 | | }
   | |_^
   |
   = note: required because of the requirements on the impl of `wundergraph::query_builder::mutations::HandleUpdate<hero::Hero, mutations::HeroChangeset, DB, Ctx>` for `Hero_table`
   = note: required because of the requirements on the impl of `juniper::GraphQLType<wundergraph::scalar::WundergraphScalarValue>` for `mutations::Mutation_inner<'a, Ctx>`
   = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)

error[E0275]: overflow evaluating the requirement `<<Hero_table as diesel::query_builder::AsQuery>::Query as diesel::query_dsl::boxed_dsl::BoxedDsl<'_, DB>>::Output`
  --> wundergraph_example/src/mutations.rs:73:1
   |
73 | / wundergraph::mutation_object! {
74 | |     /// Global mutation object for the schema
75 | |     Mutation {
76 | |         Hero(insert = NewHero, update = HeroChangeset,),
...  |
81 | |     }
82 | | }
   | |_^
   |
   = note: required because of the requirements on the impl of `wundergraph::query_builder::mutations::HandleUpdate<hero::Hero, mutations::HeroChangeset, DB, Ctx>` for `Hero_table`
   = note: required because of the requirements on the impl of `juniper::GraphQLType<wundergraph::scalar::WundergraphScalarValue>` for `mutations::Mutation_inner<'a, Ctx>`
   = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)

error[E0275]: overflow evaluating the requirement `<<Hero_table as diesel::query_builder::AsQuery>::Query as diesel::query_dsl::boxed_dsl::BoxedDsl<'_, DB>>::Output`
  --> wundergraph_example/src/mutations.rs:73:1
   |
73 | / wundergraph::mutation_object! {
74 | |     /// Global mutation object for the schema
75 | |     Mutation {
76 | |         Hero(insert = NewHero, update = HeroChangeset,),
...  |
81 | |     }
82 | | }
   | |_^
   |
   = note: required because of the requirements on the impl of `wundergraph::query_builder::mutations::HandleUpdate<hero::Hero, mutations::HeroChangeset, DB, Ctx>` for `Hero_table`
   = note: required because of the requirements on the impl of `juniper::GraphQLType<wundergraph::scalar::WundergraphScalarValue>` for `mutations::Mutation_inner<'a, Ctx>`
   = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)

error: aborting due to 12 previous errors

For more information about this error, try `rustc --explain E0275`.
error: could not compile `wundergraph_example`.

cargo bisect-rustc found that the regression happened in nightly-2020-06-21

[LeSeulArtichaut]

Let’s try to find an MCVE. @rustbot ping cleanup

[rustbot]

Hey Cleanup Crew ICE-breakers! This bug has been identified as a good
"Cleanup ICE-breaking candidate". In case it's useful, here are some
instructions for tackling these sorts of bugs. Maybe take a look?
Thanks! <3

cc @AminArria @camelid @chrissimpkins @contrun @DutchGhost @elshize @ethanboxx @h-michael @HallerPatrick @hdhoang @hellow554 @imtsuki @kanru @KarlK90 @LeSeulArtichaut @MAdrianMattocks @matheus-consoli @mental32 @nmccarty @Noah-Kennedy @pard68 @PeytonT @pierreN @Redblueflame @RobbieClarken @RobertoSnap @robjtede @SarthakSingh31 @senden9 @shekohex @sinato @spastorino @turboladen @woshilapin @yerke

[weiznich]

Corresponding commit range
From looking over those commits I think one of the following PR's could have caused that issue (based on the commit description):

• Use LocalDefId for import IDs in trait map #73357
• Suggest ?Sized when applicable for ADTs #73261?

I'm not sure if I'm able to provide a MCVE in a timely manner as some complex generic code distributed over multiple crates is involved here.

[spastorino]

Assigning P-critical as discussed as part of the Prioritization Working Group procedure and removing I-prioritize.

[spastorino]

@weiznich thanks for noting that, fixed the comment above and removed your link to avoid confusion.

[pnkfelix]

self-assigning to assist with, at least, getting an MCVE. (See also my blog post on creating MCVEs: http://blog.pnkfx.org/blog/2019/11/18/rust-bug-minimization-patterns/ )

[weiznich]

Due to time constraints I'm not able to work on a MCVE by myself. If someone needs information about diesel/wundergraph I'm happy to help.

[matthewjasper]

This is probably due to #73452 allowing cycles to be detected earlier. #73905 fixes this, but isn't suitable for a backport, so I'll open a PR that only includeds the relevant commit.

[spastorino]

Should we assign this issue to @matthewjasper given that they will work on a backport?.

[p-alik]

Trying to compile wundergraph_example with recent nightly's or the current beta ( rustc 1.46.0-beta.2 (6f959902b 2020-07-23) compiler fails with the attached error message.

The compilation succeeds with rustc 1.47.0-nightly (e15510ca3 2020-08-20) faultlessly.