Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

miri no longer builds after rust-lang/rust#79167 #79176

Closed
rust-highfive opened this issue Nov 18, 2020 · 2 comments · Fixed by #79198
Closed

miri no longer builds after rust-lang/rust#79167 #79176

rust-highfive opened this issue Nov 18, 2020 · 2 comments · Fixed by #79198
Assignees
Labels
A-miri Area: The miri tool C-bug Category: This is a bug.

Comments

@rust-highfive
Copy link
Collaborator

Hello, this is your friendly neighborhood mergebot.
After merging PR #79167, I observed that the tool miri has failing tests.
A follow-up PR to the repository https://github.com/rust-lang/miri is needed to fix the fallout.

cc @m-ou-se, do you think you would have time to do the follow-up work?
If so, that would be great!

@rust-highfive rust-highfive added A-miri Area: The miri tool C-bug Category: This is a bug. labels Nov 18, 2020
@m-ou-se
Copy link
Member

m-ou-se commented Nov 18, 2020

That PR was a rollup. Without having looked at any logs, I'm guessing this is caused by Edit: Oh uh, nope, sorry, had a different change in mind. Will take a closer look. :)

@m-ou-se
Copy link
Member

m-ou-se commented Nov 18, 2020

Ah, the problem is #78785

error: unsupported operation: unsupported Linux dlsym: getrandom
   --> /home/mara/dev-ext/rust/library/std/src/sys/unix/weak.rs:100:5
    |
100 |     libc::dlsym(libc::RTLD_DEFAULT, name.as_ptr()) as usize
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ unsupported Linux dlsym: getrandom

The call to getrandom() was changed from syscall(SYS_getrandom, ..) to try dlsym("getrandom") first. Returning null there would work fine, as it still falls back to syscall(SYS_getrandom, ..).

Edit: And the same for statx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-miri Area: The miri tool C-bug Category: This is a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants