Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't return a bool from get_word_attr #82016

Closed
jyn514 opened this issue Feb 12, 2021 · 1 comment · Fixed by #82033
Closed

Don't return a bool from get_word_attr #82016

jyn514 opened this issue Feb 12, 2021 · 1 comment · Fixed by #82033
Assignees
@magurotuna
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-help-wanted Call for participation: Help is requested to fix this issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@jyn514
Copy link
Member

jyn514 commented Feb 12, 2021 •
edited by rustbot
Loading

get_word_attr returns both an Option and whether the option is Some. This is grossly redundant, it should just return an option.
@jyn514 jyn514 added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. E-help-wanted Call for participation: Help is requested to fix this issue. labels Feb 12, 2021
@magurotuna
Copy link
Contributor

I'm interested in working on it :)
@rustbot claim

@magurotuna magurotuna mentioned this issue Feb 12, 2021
Merged
@bors bors closed this as completed in 4c8e38a Feb 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@magurotuna magurotuna

Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-help-wanted Call for participation: Help is requested to fix this issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor get_word_attr to return only Option magurotuna/rust
2 participants
@jyn514 @magurotuna