Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc renders items synchronously #82294

Closed
rylev opened this issue Feb 19, 2021 · 1 comment
Closed

rustdoc renders items synchronously #82294

rylev opened this issue Feb 19, 2021 · 1 comment
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. I-compiletime Issue: Problems and improvements with respect to compile times. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@rylev
Copy link
Member

rylev commented Feb 19, 2021

Currently rustdoc is rendering every item synchronously meaning that when there are many, many items, it takes longer than it would if these items could be processed in parallel. Moving this to being parallel won't be easy as clean::Item and html::rendered::Context are not Send for many different reasons some of which include the fact that they use datastructures from rustc that are not Send (which will rely on turning on parallel compilation to get working).

First steps to improving this is to find out where most of the time in rendering is being spent and improving that.
@jonas-schievink jonas-schievink added C-enhancement Category: An issue proposing an enhancement or a PR with one. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. I-compiletime Issue: Problems and improvements with respect to compile times. labels Feb 19, 2021
@jyn514 jyn514 mentioned this issue Mar 4, 2021
Open
5 tasks
@jyn514
Copy link
Member

jyn514 commented Mar 4, 2021

This and #82741 are basically the same issue, but #82741 has more detail, so closing this as a duplicate.

@jyn514 jyn514 closed this as completed Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. I-compiletime Issue: Problems and improvements with respect to compile times. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rylev @jonas-schievink @jyn514