Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Windows configuration with Valgrind using Wine, or Winelib #8426

Closed
mstewartgallus opened this issue Aug 10, 2013 · 7 comments
Closed
Labels
O-windows Operating system: Windows

Comments

@mstewartgallus
Copy link
Contributor

Valgrind does not run under Windows so there are two options for testing the Windows configuration of Rust with Valgrind: on a Valgrind supported platform; cross-compile to Windows, and then run the build using Wine, or compile under the Windows configuration using Winelib.

I'm not really sure which approach would be easiest. I have struggled for a while with both approaches. Personally, I think it is most logical to compile using Winelib though.

I would really appreciate if some who are more knowledgeable about the build system like @graydon, or @pnkfelix could give me some help with this.

Also, I do not know how best to expose these option to configuration.

@emberian
Copy link
Member

cc @klutzy @vadimcn @brson

Testing our memory-correctness on Windows seems pretty important to me. Nominating.

@pnkfelix
Copy link
Member

pnkfelix commented Jan 9, 2014

just a bug, denominating.

@vadimcn
Copy link
Contributor

vadimcn commented Jan 9, 2014

cc #749

@steveklabnik
Copy link
Member

@retep998 what do you think here? What's the current state of this, and shouldn't we be using some sort of windows-native tooling rather than valgrind?

@retep998
Copy link
Member

retep998 commented Sep 3, 2015

What Windows native tooling? The only thing I know of is LLVM's sanitizers.

Maybe there's something good on this list: https://en.wikipedia.org/wiki/Memory_debugger

@steveklabnik
Copy link
Member

The only thing I know of is LLVM's sanitizers.

Question answered :)

@alexcrichton
Copy link
Member

This is a pretty ancient bug, and now that we have a ton of Windows automation set up, I doubt we're going to do this. We barely even run valgrind on Linux, much less OSX, much less Windows, so I don't think that this is particularly pressing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-windows Operating system: Windows
Projects
None yet
Development

No branches or pull requests

9 participants