Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private macros are documented #88453

Closed
dylni opened this issue Aug 29, 2021 · 4 comments · Fixed by #88456
Closed

Private macros are documented #88453

dylni opened this issue Aug 29, 2021 · 4 comments · Fixed by #88456
Assignees
Labels
A-macros Area: All kinds of macros (custom derive, macro_rules!, proc macros, ..) A-visibility Area: Visibility / privacy C-bug Category: This is a bug. P-high High priority regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@dylni
Copy link
Contributor

dylni commented Aug 29, 2021

Code

I tried this code:

macro_rules! private_macro {
    () => {};
}

I expected to see this happen: private_macro is hidden from the documentation.

Instead, this happened: private_macro is shown in the documentation and has its own page. Private declarative macros are also shown.

Version it worked on

It most recently worked on: rustc 1.56.0-nightly (8007b50 2021-08-14)

Version with regression

rustc --version:

rustc 1.56.0-nightly (5eacec9ec 2021-08-28)
@dylni dylni added C-bug Category: This is a bug. regression-untriaged Untriaged performance or correctness regression. labels Aug 29, 2021
@rustbot rustbot added I-prioritize Issue: Indicates that prioritization has been requested for this issue. A-macros Area: All kinds of macros (custom derive, macro_rules!, proc macros, ..) A-visibility Area: Visibility / privacy T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. and removed I-prioritize Issue: Indicates that prioritization has been requested for this issue. regression-untriaged Untriaged performance or correctness regression. labels Aug 29, 2021
@dylni
Copy link
Contributor Author

dylni commented Aug 29, 2021

@rustbot modify labels +requires-nightly

@rustbot rustbot added the requires-nightly This issue requires a nightly compiler in some way. label Aug 29, 2021
@inquisitivecrystal inquisitivecrystal added regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. and removed requires-nightly This issue requires a nightly compiler in some way. labels Aug 29, 2021
@rustbot rustbot added the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Aug 29, 2021
@inquisitivecrystal
Copy link
Contributor

Thanks for filing this issue!

This regression was almost certainly introduced in #88019. I'm looking into it.

@camelid
Copy link
Member

camelid commented Aug 29, 2021

Assigning priority as discussed in the prioritization working group.

@rustbot label: +P-high -I-prioritize

@rustbot rustbot added P-high High priority and removed I-prioritize Issue: Indicates that prioritization has been requested for this issue. labels Aug 29, 2021
@bors bors closed this as completed in dbb0fe9 Aug 30, 2021
@dylni
Copy link
Contributor Author

dylni commented Sep 6, 2021

Thanks @inquisitivecrystal!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-macros Area: All kinds of macros (custom derive, macro_rules!, proc macros, ..) A-visibility Area: Visibility / privacy C-bug Category: This is a bug. P-high High priority regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants