Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UWP implementations weren't updated for I/O safety #88764

Closed
jdm opened this issue Sep 8, 2021 · 3 comments
Closed

UWP implementations weren't updated for I/O safety #88764

jdm opened this issue Sep 8, 2021 · 3 comments
Labels
A-io Area: `std::io`, `std::fs`, `std::net` and `std::path` C-bug Category: This is a bug. O-windows Operating system: Windows P-high High priority regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Comments

@jdm
Copy link
Contributor

jdm commented Sep 8, 2021

d154185 updated lots of code in library/std/src/sys/windows/ to use the new APIs, but did not modify usages in the conitional UWP implementations like:

This manifests as a bunch of compile errors when building with --target x86_64-uwp-windows-msvc and -Z build-std.

@jdm jdm added regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. C-bug Category: This is a bug. labels Sep 8, 2021
@rustbot rustbot added the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Sep 8, 2021
@camelid camelid added O-windows Operating system: Windows A-io Area: `std::io`, `std::fs`, `std::net` and `std::path` T-libs Relevant to the library team, which will review and decide on the PR/issue. O-windows-msvc Toolchain: MSVC, Operating system: Windows and removed O-windows-msvc Toolchain: MSVC, Operating system: Windows labels Sep 8, 2021
@apiraino
Copy link
Contributor

apiraino commented Sep 9, 2021

Assigning priority as discussed in the Zulip thread of the Prioritization Working Group.

@rustbot label -I-prioritize +P-high

@rustbot rustbot added P-high High priority and removed I-prioritize Issue: Indicates that prioritization has been requested for this issue. labels Sep 9, 2021
@ghost
Copy link

ghost commented Sep 9, 2021

It looks like that #88587 is intended to fix this.

@cuviper cuviper added regression-from-stable-to-beta Performance or correctness regression from stable to beta. and removed regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. labels Sep 14, 2021
@nbdd0121
Copy link
Contributor

nbdd0121 commented Oct 5, 2021

Given that #89527 contains #88587, should this be closed?

@m-ou-se m-ou-se closed this as completed Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-io Area: `std::io`, `std::fs`, `std::net` and `std::path` C-bug Category: This is a bug. O-windows Operating system: Windows P-high High priority regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

7 participants