Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC 2229 - closure migration suggestion bug? #89080

Closed
Mark-Simulacrum opened this issue Sep 18, 2021 · 3 comments
Closed

RFC 2229 - closure migration suggestion bug? #89080

Mark-Simulacrum opened this issue Sep 18, 2021 · 3 comments
Labels
A-edition-2021 Area: The 2021 edition
Milestone

Comments

@Mark-Simulacrum
Copy link
Member

https://github.com/rust-lang/rust/pull/89075/files#r711626103 notes that our migrations suggested adding a let _ = &config; here. However, I would've expected that to not happen, because config is not a type with significant destructors (as far as I can tell). Maybe there's a bug here?

config has type LangString, which only contains Vec<String>, but I would expect that type to not trigger our migration tooling as it has trivial dtors.

cc @rust-lang/wg-rfc-2229

@Mark-Simulacrum Mark-Simulacrum added the A-edition-2021 Area: The 2021 edition label Sep 18, 2021
@Mark-Simulacrum Mark-Simulacrum added this to the 1.56.0 milestone Sep 21, 2021
@Mark-Simulacrum
Copy link
Member Author

Based on Zulip discussion it sounds like this is caused by not yet adding the insignificant dtor attributes to std, and @arora-aman is going to work on a PR to do that. We may consider backporting that.

@Mark-Simulacrum
Copy link
Member Author

I believe this is fixed by #89144 -- going to try to confirm locally.

@Mark-Simulacrum
Copy link
Member Author

Confirmed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-edition-2021 Area: The 2021 edition
Projects
None yet
Development

No branches or pull requests

1 participant