Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NLL] Many errors generated instead of one with many notes #96278

Open
marmeladema opened this issue Apr 21, 2022 · 2 comments
Open

[NLL] Many errors generated instead of one with many notes #96278

marmeladema opened this issue Apr 21, 2022 · 2 comments
Labels
A-diagnostics Area: Messages for errors, warnings, and lints A-NLL Area: Non-lexical lifetimes (NLL) NLL-diagnostics Working towards the "diagnostic parity" goal T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@marmeladema
Copy link
Contributor

In tests like:

Under NLL we generate many errors for almost the same span instead of one error with many notes under migrate mode, which is more readable and easier to understand.

We should fix this.

@rustbot label +A-NLL +NLL-diagnostics
@marmeladema marmeladema added A-diagnostics Area: Messages for errors, warnings, and lints T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 21, 2022
@rustbot rustbot added A-NLL Area: Non-lexical lifetimes (NLL) NLL-diagnostics Working towards the "diagnostic parity" goal labels Apr 21, 2022
@marmeladema marmeladema mentioned this issue Apr 21, 2022
Merged
@jackh726
Copy link
Member

Any way this is fixed by #96236?

@marmeladema
Copy link
Contributor Author

No, I rebased over current master and blessed all the tests and nothing changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-diagnostics Area: Messages for errors, warnings, and lints A-NLL Area: Non-lexical lifetimes (NLL) NLL-diagnostics Working towards the "diagnostic parity" goal T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@marmeladema @jackh726 @rustbot