Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x.py test tests/ doesn't work #97314

Closed
est31 opened this issue May 23, 2022 · 4 comments · Fixed by #121372
Closed

x.py test tests/ doesn't work #97314

est31 opened this issue May 23, 2022 · 4 comments · Fixed by #121372
Labels
E-help-wanted Call for participation: Help is requested to fix this issue. E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@est31
Copy link
Member

est31 commented May 23, 2022

If you try to do ./x.py test src/test, it doesn't work:

./x.py test --stage 1 src/test/ --bless
Updating only changed submodules
  Submodules updated in 0.01 seconds
Building rustbuild
    Finished dev [unoptimized] target(s) in 0.14s
error: no `test` rules matched 'src/test/'
help: run `x.py test --help --verbose` to show a list of available paths
note: if you are adding a new Step to bootstrap itself, make sure you register it with `describe!`
Build completed unsuccessfully in 0:00:00

Same goes for x.py test compiler and x.py test library.

@rustbot label A-rustbuild

@rustbot rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label May 23, 2022
@RalfJung
Copy link
Member

Why did you expect these to work?
The following should work: ./x.py test src/test/ui, ./x.py test library/core. I think currently this is by design.

Or is this a feature request to make ./x.py test src/test basically ./x.py test src/test/*?

@est31
Copy link
Member Author

est31 commented Aug 26, 2022

Yeah it's a feature request. I filed it upon invitation of @jyn514 after he asked about pain points of bootstrap : https://rust-lang.zulipchat.com/#narrow/stream/122651-general/topic/pain.20points.20of.20bootstrap/near/283314219

@est31
Copy link
Member Author

est31 commented Aug 26, 2022

Or is this a feature request to make ./x.py test src/test basically ./x.py test src/test/*?

Yeah this exactly.

@est31 est31 changed the title x.py test src/test doesn't work x.py test tests/ doesn't work Feb 1, 2023
@est31
Copy link
Member Author

est31 commented Feb 1, 2023

Update: still doesn't work today (now with the tests/ dir).

@albertlarsan68 albertlarsan68 self-assigned this Feb 1, 2023
@albertlarsan68 albertlarsan68 removed their assignment Apr 26, 2023
@albertlarsan68 albertlarsan68 added E-help-wanted Call for participation: Help is requested to fix this issue. E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. labels Apr 26, 2023
@jyn514 jyn514 changed the title x.py test tests/ doesn't work x.py test tests/ doesn't work May 24, 2023
@bors bors closed this as completed in 933a05b Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-help-wanted Call for participation: Help is requested to fix this issue. E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants