diff --git a/src/librustc/session/config.rs b/src/librustc/session/config.rs index 9a5e929d85f2d..365ad880c4b18 100644 --- a/src/librustc/session/config.rs +++ b/src/librustc/session/config.rs @@ -246,6 +246,10 @@ impl OutputTypes { self.0.values() } + pub fn len(&self) -> usize { + self.0.len() + } + // True if any of the output types require codegen or linking. pub fn should_trans(&self) -> bool { self.0.keys().any(|k| match *k { diff --git a/src/librustc_driver/driver.rs b/src/librustc_driver/driver.rs index a3115544f30b9..44fc819ebb777 100644 --- a/src/librustc_driver/driver.rs +++ b/src/librustc_driver/driver.rs @@ -168,7 +168,7 @@ pub fn compile_input(trans: Box, write_out_deps(sess, &outputs, &output_paths); if sess.opts.output_types.contains_key(&OutputType::DepInfo) && - sess.opts.output_types.keys().count() == 1 { + sess.opts.output_types.len() == 1 { return Ok(()) } diff --git a/src/librustc_metadata/encoder.rs b/src/librustc_metadata/encoder.rs index 39de1ec852ec4..767ab82aa34b4 100644 --- a/src/librustc_metadata/encoder.rs +++ b/src/librustc_metadata/encoder.rs @@ -833,6 +833,11 @@ impl<'a, 'b: 'a, 'tcx: 'b> IsolatedEncoder<'a, 'b, 'tcx> { } } + fn metadata_output_only(&self) -> bool { + // MIR optimisation can be skipped when we're just interested in the metadata. + !self.tcx.sess.opts.output_types.should_trans() + } + fn encode_info_for_impl_item(&mut self, def_id: DefId) -> Entry<'tcx> { debug!("IsolatedEncoder::encode_info_for_impl_item({:?})", def_id); let tcx = self.tcx; @@ -877,7 +882,8 @@ impl<'a, 'b: 'a, 'tcx: 'b> IsolatedEncoder<'a, 'b, 'tcx> { } else if let hir::ImplItemKind::Method(ref sig, body) = ast_item.node { let generics = self.tcx.generics_of(def_id); let types = generics.parent_types as usize + generics.types.len(); - let needs_inline = types > 0 || tcx.trans_fn_attrs(def_id).requests_inline(); + let needs_inline = (types > 0 || tcx.trans_fn_attrs(def_id).requests_inline()) && + !self.metadata_output_only(); let is_const_fn = sig.constness == hir::Constness::Const; let ast = if is_const_fn { Some(body) } else { None }; let always_encode_mir = self.tcx.sess.opts.debugging_opts.always_encode_mir; @@ -1168,7 +1174,8 @@ impl<'a, 'b: 'a, 'tcx: 'b> IsolatedEncoder<'a, 'b, 'tcx> { hir::ItemConst(..) => self.encode_optimized_mir(def_id), hir::ItemFn(_, _, constness, _, ref generics, _) => { let has_tps = generics.ty_params().next().is_some(); - let needs_inline = has_tps || tcx.trans_fn_attrs(def_id).requests_inline(); + let needs_inline = (has_tps || tcx.trans_fn_attrs(def_id).requests_inline()) && + !self.metadata_output_only(); let always_encode_mir = self.tcx.sess.opts.debugging_opts.always_encode_mir; if needs_inline || constness == hir::Constness::Const || always_encode_mir { self.encode_optimized_mir(def_id)