Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary size on multiple targets #1760

Open
tgross35 opened this issue Nov 30, 2023 · 3 comments
Open

Binary size on multiple targets #1760

tgross35 opened this issue Nov 30, 2023 · 3 comments

Comments

@tgross35
Copy link

Based on rust-lang/wg-binary-size#3, we would like to see binary size outputs on a few different targets show up as perf results. Just checking output size should be relatively fast compared to benchmarking so we can probably include any std targets that we can cross compile to, as well as something WASM and a few popular no_std targets.

It would be extra nice if the report could hold expanded details about the size of each section, but that is a bonus rather than a core feature.

@Kobzol
Copy link
Contributor

Kobzol commented Dec 2, 2023

I guess that we should do something first-class for measuring the binary size, rather than the current two hacky "-tiny" benchmarks. For the use-cases that you have envisioned, would it be enough to all of them to cross-compile from Linux x64?

Regarding the binary sections, I thought about it, and it would be possible, but we'd need to store relatively a lot of data into the DB, if we did it eagerly. And we can't really do it lazely, because the server does not get access to the built binaries (they are actually immediately deleted).

I wonder if it would be useful as a start to have a command in rustc-perf to show the binary sections at least locally?

@tgross35
Copy link
Author

tgross35 commented Dec 2, 2023

I think cross compilation is definitely fine, especially since some targets are always cross compiled.

Sections really isn't necessary. That was just an idea for a quick geiger counter of where changes were, without replicating the build locally.

@Kobzol
Copy link
Contributor

Kobzol commented Jan 12, 2024

#1772 implemented a new local command to examine the section and symbol sizes of compile benchmarks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants