Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the default value of imports_indent to IndentStyle::Block #2657

Closed
topecongiro opened this issue Apr 28, 2018 · 0 comments
Closed

Change the default value of imports_indent to IndentStyle::Block #2657

topecongiro opened this issue Apr 28, 2018 · 0 comments
Labels
good first issue Issues up for grabs, also good candidates for new rustfmt contributors

Comments

@topecongiro
Copy link
Contributor

topecongiro commented Apr 28, 2018 •
edited
Loading

AFAICT from the discussoin in rust-lang/style-team#24, the consensus is formed toward perfering block indent over visual indent for imports. Changing the default value will be a big change, so I think that we should do it sooner rather than later.
@topecongiro topecongiro added the good first issue Issues up for grabs, also good candidates for new rustfmt contributors label Apr 28, 2018
@csmoe csmoe mentioned this issue Apr 29, 2018
Merged
@nrc nrc closed this as completed in #2662 Apr 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Issues up for grabs, also good candidates for new rustfmt contributors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@topecongiro