Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Change the default behavior of rustfmt to not to format sub-modules #3587

Closed
topecongiro opened this issue May 27, 2019 · 1 comment · Fixed by #3938
Closed

[RFC] Change the default behavior of rustfmt to not to format sub-modules #3587

topecongiro opened this issue May 27, 2019 · 1 comment · Fixed by #3938
Milestone

Comments

@topecongiro
Copy link
Contributor

Summary

Change the default behavior of rustfmt to not to format sub-modules of the given files by default. The behavior of cargo fmt will not change with this proposal.

Steps

  1. Change the default behavior of rustfmt to not to format sub-modules
  2. Deprecate --skip-children (as it will the default)
  3. Add -r,--recursive command line option, when if present, rustfmt will format the given files and their sub-modules (the current default)
@topecongiro topecongiro added this to the 2.0.0 milestone May 27, 2019
@otavio
Copy link
Contributor

otavio commented May 27, 2019

Given cargo fmt behavior does not change, I think it does make sense so it is, in fact, applying at the given file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants